Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[FrameworkBundle] show public/private for aliases in debug:container command#27551

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
nicolas-grekas merged 1 commit intosymfony:masterfromOskarStark:show-public-property-for-alias
Jun 19, 2018
Merged

[FrameworkBundle] show public/private for aliases in debug:container command#27551

nicolas-grekas merged 1 commit intosymfony:masterfromOskarStark:show-public-property-for-alias
Jun 19, 2018

Conversation

@OskarStark
Copy link
Contributor

@OskarStarkOskarStark commentedJun 8, 2018•
edited
Loading

QA
Branch?master
Bug fix?no
New feature?yes
BC breaks?no
Deprecations?no
Tests pass?yes
Fixed tickets
LicenseMIT
Doc PRnot needed

It could be helpful to see the public/private status for aliases indebug:container command.

Otherwise you need to dive into the code to get the information, because the result only shows the options of the aliased service.

Look & Feel for public alias

screenshot 2018-06-08 09 25 50

text has slightly changed

Look & Feel for private alias

screenshot 2018-06-08 09 23 31

text has slightly changed

//cc@nicolas-grekas

@linaori
Copy link
Contributor

I like this, small but useful! I noticed your screenshots mention "an public/private alias", but it's already fixed in your code (in case people notice this).

@OskarStark
Copy link
ContributorAuthor

OskarStark commentedJun 8, 2018•
edited
Loading

I like this, small but useful!

Thank you 😄

I noticed your screenshots mention "an public/private alias", but it's already fixed in your code (in case people notice this).

Yes, thats what I mean bytext has slightly changed below the screenshots 👍

@nicolas-grekas
Copy link
Member

CI is failing due to some console width issue, can you update the tests to force a specific width? (there are other places doing so, can't recall right now)

@chalasrchalasr added this to thenext milestoneJun 8, 2018
@chalasr
Copy link
Member

Features are for master. The console width is forced there so rebasing and regenerating the fixture should make tests green.

@OskarStark
Copy link
ContributorAuthor

Features are for master.

Indeed, you are right, but I talked to@nicolas-grekas and we think it could be also merged as patch.
In this case we could get this from 2.8 upwards. WDYT?
But in this case we need to force the console width in this branch, too, right?

@fabpot
Copy link
Member

New features are for master only.

@OskarStark
Copy link
ContributorAuthor

New features are for master only.

ok I will rebase my branch 👍

@OskarStarkOskarStark changed the base branch from2.8 tomasterJune 8, 2018 11:41
@OskarStarkOskarStark changed the title[WIP] [FrameworkBundle] show public/private for aliases in debug:container command[FrameworkBundle] show public/private for aliases in debug:container commandJun 8, 2018
@OskarStark
Copy link
ContributorAuthor

TBH I could not get the tests running, due to whitespaces, line endings or something else.
Tried vim and PHPStorm on a MacBook 😢

@OskarStark
Copy link
ContributorAuthor

screenshot 2018-06-08 13 57 24

This is the problem

@chalasrchalasr self-requested a reviewJune 16, 2018 04:59
@OskarStark
Copy link
ContributorAuthor

Can anybody help me finishing this PR?

I can give access to my fork too ofc

@nicolas-grekas
Copy link
Member

Tests fixed.

@nicolas-grekas
Copy link
Member

Thank you@OskarStark.

OskarStark reacted with thumbs up emoji

@nicolas-grekasnicolas-grekas merged commit1df7742 intosymfony:masterJun 19, 2018
nicolas-grekas added a commit that referenced this pull requestJun 19, 2018
…ebug:container command (OskarStark)This PR was merged into the 4.2-dev branch.Discussion----------[FrameworkBundle] show public/private for aliases in debug:container command| Q             | A| ------------- | ---| Branch?       |  master| Bug fix?      | no| New feature?  | yes <!-- don't forget to update src/**/CHANGELOG.md files -->| BC breaks?    | no     <!-- seehttps://symfony.com/bc -->| Deprecations? | no <!-- don't forget to update UPGRADE-*.md and src/**/CHANGELOG.md files -->| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->| Fixed tickets |    <!-- #-prefixed issue number(s), if any -->| License       | MIT| Doc PR        | not needed <!-- required for new features -->It could be helpful to see the public/private status for aliases in `debug:container` command.Otherwise you need to dive into the code to get the information, because the result only shows the options of the aliased service.## Look & Feel for public alias![screenshot 2018-06-08 09 25 50](https://user-images.githubusercontent.com/995707/41144664-f3b50766-6afd-11e8-92d0-ca30513a1afc.png)_text has slightly changed_## Look & Feel for private alias![screenshot 2018-06-08 09 23 31](https://user-images.githubusercontent.com/995707/41144593-b354aad2-6afd-11e8-8ab1-f9196e567f67.png)_text has slightly changed_//cc@nicolas-grekasCommits-------1df7742 [FrameworkBundle] show public/private for aliases in debug:container command
@OskarStarkOskarStark deleted the show-public-property-for-alias branchJune 19, 2018 11:05
@nicolas-grekasnicolas-grekas modified the milestones:next,4.2Nov 1, 2018
This was referencedNov 3, 2018
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@nicolas-grekasnicolas-grekasnicolas-grekas approved these changes

@chalasrchalasrchalasr approved these changes

@dunglasdunglasAwaiting requested review from dunglas

@lyrixxlyrixxAwaiting requested review from lyrixx

@srozesrozeAwaiting requested review from sroze

Assignees

No one assigned

Projects

None yet

Milestone

4.2

Development

Successfully merging this pull request may close these issues.

6 participants

@OskarStark@linaori@nicolas-grekas@chalasr@fabpot@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp