NotificationsYou must be signed in to change notification settings
Fork9.7k
Star30.8k

Revert "bug #26138 [HttpKernel] Catch HttpExceptions when templating is not installed (cilefen)"#27516

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

nicolas-grekas merged 1 commit intosymfony:3.4fromnicolas-grekas:http-x-revert

Jun 6, 2018

Merged

Revert "bug #26138 [HttpKernel] Catch HttpExceptions when templating is not installed (cilefen)"#27516

nicolas-grekas merged 1 commit intosymfony:3.4fromnicolas-grekas:http-x-revert

Jun 6, 2018

Conversation

Copy link

Member

nicolas-grekas commentedJun 6, 2018

Q	A
Branch?	3.4
Bug fix?	yes
New feature?	no
BC breaks?	no
Deprecations?	no
Tests pass?	yes
Fixed tickets	#27212
License	MIT
Doc PR	-

This reverts commitb213c5a, reversing
changes made to61af0e3.

This breaks BC and is more like a new feature, let's move this on master.

Revert "bugsymfony#26138[HttpKernel] Catch HttpExceptions when temp…

c6acad7

…lating is not installed (cilefen)"This reverts commitb213c5a, reversingchanges made to61af0e3.

nicolas-grekas added this to the3.4 milestone

Jun 6, 2018

carsonbot added Status: Needs Review HttpKernel Bug labels

Jun 6, 2018

nicolas-grekas mentioned this pull request

Jun 6, 2018

[HttpKernel] Turn HTTP exceptions to responses on terminateWithException()#27505

Closed

Copy link

Member

chalasr commentedJun 6, 2018

c93c9a5 will need to be reverted when merging this into 4.1.

carsonbot added Status: Reviewed and removed Status: Needs Review labels

Jun 6, 2018

chalasr approved these changes

Jun 6, 2018

View reviewed changes

fabpot approved these changes

Jun 6, 2018

View reviewed changes

nicolas-grekas merged commitc6acad7 intosymfony:3.4

Jun 6, 2018

nicolas-grekas added a commit that referenced this pull request

Jun 6, 2018

bug#27516Revert "bug#26138[HttpKernel] Catch HttpExceptions when …

4435144

…templating is not installed (cilefen)" (nicolas-grekas)This PR was merged into the 3.4 branch.Discussion----------Revert "bug#26138 [HttpKernel] Catch HttpExceptions when templating is not installed (cilefen)"| Q             | A| ------------- | ---| Branch?       | 3.4| Bug fix?      | yes| New feature?  | no| BC breaks?    | no| Deprecations? | no| Tests pass?   | yes| Fixed tickets |#27212| License       | MIT| Doc PR        | -This reverts commitb213c5a, reversingchanges made to61af0e3.This breaks BC and is more like a new feature, let's move this on master.Commits-------c6acad7 Revert "bug#26138 [HttpKernel] Catch HttpExceptions when templating is not installed (cilefen)"