Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[DI] Ignore missing tree root nodes on validate#27472
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Member
nicolas-grekas commentedJun 1, 2018
LGTM, with a test case would be even better :) |
nicolas-grekas approved these changesJun 2, 2018
xabbuh requested changesJun 2, 2018
Member
xabbuh left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
The conflict rule for the DependencyInjection component must now be updated:
"symfony/config": "<4.1.1"ContributorAuthor
ro0NL commentedJun 3, 2018
nice catch. Done status: needs review |
fabpot approved these changesJun 5, 2018
Member
fabpot commentedJun 5, 2018
Thank you@ro0NL. |
fabpot added a commit that referenced this pull requestJun 5, 2018
This PR was squashed before being merged into the 4.1 branch (closes#27472).Discussion----------[DI] Ignore missing tree root nodes on validate| Q | A| ------------- | ---| Branch? | 4.1| Bug fix? | yes| New feature? | technically yes| BC breaks? | no <!-- seehttps://symfony.com/bc -->| Deprecations? | no| Tests pass? | yes <!-- please add some, will be required by reviewers -->| Fixed tickets |#27450| License | MIT| Doc PR | symfony/symfony-docs#... <!-- required for new features --><!--Write a short README entry for your feature/bugfix here (replace this comment block.)This will help people understand your PR and can be used as a start of the Doc PR.Additionally: - Bug fixes must be submitted against the lowest branch where they apply (lowest branches are regularly merged to upper ones so they get the fixes too). - Features and deprecations must be submitted against the master branch.-->Commits-------b3cdfc6 [DI] Ignore missing tree root nodes on validate
Merged
fabpot added a commit that referenced this pull requestJun 25, 2018
…abbuh)This PR was merged into the 4.2-dev branch.Discussion----------[Config] deprecate tree builders without root nodes| Q | A| ------------- | ---| Branch? | master| Bug fix? | no| New feature? | yes| BC breaks? | no| Deprecations? | yes| Tests pass? | yes| Fixed tickets || License | MIT| Doc PR |While reviewing#27472 I wondered if we really need support config trees without a root node. If we did not support it, users wouldn't create pseudo configuration classes when they were actually not needed.Commits-------c2ce153 deprecate tree builders without root nodes
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.