Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[DI] Ignore missing tree root nodes on validate#27472

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fabpot merged 1 commit intosymfony:4.1fromro0NL:di/env-config
Jun 5, 2018
Merged

[DI] Ignore missing tree root nodes on validate#27472

fabpot merged 1 commit intosymfony:4.1fromro0NL:di/env-config
Jun 5, 2018

Conversation

@ro0NL
Copy link
Contributor

@ro0NLro0NL commentedJun 1, 2018
edited
Loading

QA
Branch?4.1
Bug fix?yes
New feature?technically yes
BC breaks?no
Deprecations?no
Tests pass?yes
Fixed tickets#27450
LicenseMIT
Doc PRsymfony/symfony-docs#...

@nicolas-grekas
Copy link
Member

LGTM, with a test case would be even better :)

Copy link
Member

@xabbuhxabbuh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

The conflict rule for the DependencyInjection component must now be updated:

"symfony/config": "<4.1.1"

@ro0NL
Copy link
ContributorAuthor

nice catch. Done

status: needs review

@fabpot
Copy link
Member

Thank you@ro0NL.

@fabpotfabpot merged commitb3cdfc6 intosymfony:4.1Jun 5, 2018
fabpot added a commit that referenced this pull requestJun 5, 2018
This PR was squashed before being merged into the 4.1 branch (closes#27472).Discussion----------[DI] Ignore missing tree root nodes on validate| Q             | A| ------------- | ---| Branch?       | 4.1| Bug fix?      | yes| New feature?  | technically yes| BC breaks?    | no     <!-- seehttps://symfony.com/bc -->| Deprecations? | no| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->| Fixed tickets |#27450| License       | MIT| Doc PR        | symfony/symfony-docs#... <!-- required for new features --><!--Write a short README entry for your feature/bugfix here (replace this comment block.)This will help people understand your PR and can be used as a start of the Doc PR.Additionally: - Bug fixes must be submitted against the lowest branch where they apply   (lowest branches are regularly merged to upper ones so they get the fixes too). - Features and deprecations must be submitted against the master branch.-->Commits-------b3cdfc6 [DI] Ignore missing tree root nodes on validate
@ro0NLro0NL deleted the di/env-config branchJune 5, 2018 06:41
@fabpotfabpot mentioned this pull requestJun 25, 2018
fabpot added a commit that referenced this pull requestJun 25, 2018
…abbuh)This PR was merged into the 4.2-dev branch.Discussion----------[Config] deprecate tree builders without root nodes| Q             | A| ------------- | ---| Branch?       | master| Bug fix?      | no| New feature?  | yes| BC breaks?    | no| Deprecations? | yes| Tests pass?   | yes| Fixed tickets || License       | MIT| Doc PR        |While reviewing#27472 I wondered if we really need support config trees without a root node. If we did not support it, users wouldn't create pseudo configuration classes when they were actually not needed.Commits-------c2ce153 deprecate tree builders without root nodes
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@xabbuhxabbuhxabbuh requested changes

@fabpotfabpotfabpot approved these changes

@nicolas-grekasnicolas-grekasnicolas-grekas approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

4.1

Development

Successfully merging this pull request may close these issues.

6 participants

@ro0NL@nicolas-grekas@fabpot@xabbuh@ogizanagi@carsonbot

[8]ページ先頭

©2009-2025 Movatter.jp