Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[PropertyInfo] Add an alias to the property info type extractor#27430
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
fabpot merged 1 commit intosymfony:masterfromsroze:add-alias-to-property-info-type-extractorMay 31, 2018
Merged
[PropertyInfo] Add an alias to the property info type extractor#27430
fabpot merged 1 commit intosymfony:masterfromsroze:add-alias-to-property-info-type-extractorMay 31, 2018
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Member
dunglas commentedMay 30, 2018
We should do it for all specific interfaces then, right? |
45e9ac5 tobbbcd46CompareContributorAuthor
sroze commentedMay 30, 2018
@dunglas good point; added them 👍 |
dunglas approved these changesMay 30, 2018
ogizanagi approved these changesMay 30, 2018
Member
fabpot commentedMay 31, 2018
Thank you@sroze. |
fabpot approved these changesMay 31, 2018
fabpot added a commit that referenced this pull requestMay 31, 2018
…extractor (sroze)This PR was merged into the 4.2-dev branch.Discussion----------[PropertyInfo] Add an alias to the property info type extractor| Q | A| ------------- | ---| Branch? | master| Bug fix? | no| New feature? | yes| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets |#27139| License | MIT| Doc PR | øAs spotted in#27139, we only alias the main PropertyInfo interface but we don't alias the other one, gathering only the types (while we implement it). This fixes the "problem" of auto-wiring it.Commits-------bbbcd46 Add an alias to the property info type extractor
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As spotted in#27139, we only alias the main PropertyInfo interface but we don't alias the other one, gathering only the types (while we implement it). This fixes the "problem" of auto-wiring it.