Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[WebProfilerBundle] Make Twig bundle an explicit dependency#27417

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fabpot merged 1 commit intosymfony:masterfromfabpot:profiler-twig-dep
May 30, 2018

Conversation

@fabpot
Copy link
Member

QA
Branch?master
Bug fix?no
New feature?yes
BC breaks?no
Deprecations?no
Tests pass?yes
Fixed tickets#26115
LicenseMIT

Let's make Twig bundle an explicit dependency of WebProfilerBundle. That's better for DX and as Silex won't be maintained when 4.2 is out, it's the right time to do so.

apetitpa reacted with thumbs up emoji
@plozmun
Copy link
Contributor

plozmun commentedMay 30, 2018•
edited
Loading

Shouldn't it be the WebProfilerBundle composer instead TwigBundle? It's referencing itself

ogizanagi
ogizanagi previously requested changesMay 30, 2018
"symfony/http-kernel":"~3.4|~4.0",
"symfony/polyfill-ctype":"~1.8",
"twig/twig":"~1.34|~2.4"
"symfony/twig-bundle":"^3.4.3|^4.0.3",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

You're looking for troubles by requiring it itself 😅
Should actually be inSymfony/Bundle/WebProfilerBundle/composer.json, not TwigBundle's composer.json.

@nicolas-grekasnicolas-grekas added this to thenext milestoneMay 30, 2018
@ogizanagiogizanagi dismissed theirstale reviewMay 30, 2018 07:53

deps fixed

@fabpotfabpot merged commitcac37ca intosymfony:masterMay 30, 2018
fabpot added a commit that referenced this pull requestMay 30, 2018
…dency (fabpot)This PR was merged into the 4.2-dev branch.Discussion----------[WebProfilerBundle] Make Twig bundle an explicit dependency| Q             | A| ------------- | ---| Branch?       | master| Bug fix?      | no| New feature?  | yes| BC breaks?    | no| Deprecations? | no| Tests pass?   | yes| Fixed tickets |#26115| License       | MITLet's make Twig bundle an explicit dependency of WebProfilerBundle. That's better for DX and as Silex won't be maintained when 4.2 is out, it's the right time to do so.Commits-------cac37ca [WebProfilerBundle] made Twig bundle an explicit dependency
@nicolas-grekasnicolas-grekas modified the milestones:next,4.2Nov 1, 2018
This was referencedNov 3, 2018
@fabpotfabpot deleted the profiler-twig-dep branchJanuary 14, 2019 11:01
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@nicolas-grekasnicolas-grekasnicolas-grekas approved these changes

@stofstofstof approved these changes

+1 more reviewer

@ogizanagiogizanagiogizanagi approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Projects

None yet

Milestone

4.2

Development

Successfully merging this pull request may close these issues.

6 participants

@fabpot@plozmun@nicolas-grekas@stof@ogizanagi@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp