Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Form] Fix error when rendering a DateIntervalType form with exactly 0 weeks#27382

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

@krixon
Copy link

@krixonkrixon commentedMay 25, 2018•
edited
Loading

QA
Branch?3.4
Bug fix?yes
New feature?no
BC breaks?no
Deprecations?no
Tests pass?yes
Fixed tickets#27378
LicenseMIT

Fixes the issue described in#27378

@nicolas-grekasnicolas-grekas added this to the3.4 milestoneMay 25, 2018
@nicolas-grekasnicolas-grekas changed the titleFix #27378: Error when rendering a DateIntervalType form with exactly…[Form] Error when rendering a DateIntervalType form with exactly 0 weeksJun 15, 2018
@nicolas-grekasnicolas-grekas changed the title[Form] Error when rendering a DateIntervalType form with exactly 0 weeks[Form] Fix error when rendering a DateIntervalType form with exactly 0 weeksJun 15, 2018
@nicolas-grekas
Copy link
Member

Note that 3.2 is not maintained anymore so that this should be merged on 3.4 (or 2.8 if the issue exists there. Does it?)

@nicolas-grekas
Copy link
Member

(please check tests and CS failures also)

@krixonkrixonforce-pushed thedateinterval-array-transformer branch from9ab0b48 todae704aCompareJune 18, 2018 12:03
@krixonkrixon changed the base branch from3.2 to3.4June 18, 2018 12:05
@krixon
Copy link
Author

Note that 3.2 is not maintained anymore so that this should be merged on 3.4 (or 2.8 if the issue exists there. Does it?)

Thanks, I've rebased onto 3.4 and updated the PR target accordingly. The problem does not exist in 2.8.

please check tests and CS failures also

I am still seeing some test failures locally, however I see the same failures on the 3.4 branch itself - they are unrelated to my changes. I've included details of these errors below. I am also not sure why AppVeyor thinks it can't build this branch - could you advise on how to proceed please?

1) Symfony\Component\Ldap\Tests\AdapterTest::testLdapQuerySymfony\Component\Ldap\Exception\ConnectionException: Can't contact LDAP server/home/karl/code/krixon/symfony/src/Symfony/Component/Ldap/Adapter/ExtLdap/Connection.php:54/home/karl/code/krixon/symfony/src/Symfony/Component/Ldap/Tests/Adapter/ExtLdap/AdapterTest.php:402) Symfony\Component\Ldap\Tests\AdapterTest::testLdapQueryIteratorSymfony\Component\Ldap\Exception\ConnectionException: Can't contact LDAP server/home/karl/code/krixon/symfony/src/Symfony/Component/Ldap/Adapter/ExtLdap/Connection.php:54/home/karl/code/krixon/symfony/src/Symfony/Component/Ldap/Tests/Adapter/ExtLdap/AdapterTest.php:603) Symfony\Component\Ldap\Tests\AdapterTest::testLdapQueryScopeBaseSymfony\Component\Ldap\Exception\ConnectionException: Can't contact LDAP server/home/karl/code/krixon/symfony/src/Symfony/Component/Ldap/Adapter/ExtLdap/Connection.php:54/home/karl/code/krixon/symfony/src/Symfony/Component/Ldap/Tests/Adapter/ExtLdap/AdapterTest.php:864) Symfony\Component\Ldap\Tests\AdapterTest::testLdapQueryScopeOneLevelSymfony\Component\Ldap\Exception\ConnectionException: Can't contact LDAP server/home/karl/code/krixon/symfony/src/Symfony/Component/Ldap/Adapter/ExtLdap/Connection.php:54/home/karl/code/krixon/symfony/src/Symfony/Component/Ldap/Tests/Adapter/ExtLdap/AdapterTest.php:1025) Symfony\Component\Ldap\Tests\LdapManagerTest::testLdapAddAndRemoveSymfony\Component\Ldap\Exception\ConnectionException: Can't contact LDAP server/home/karl/code/krixon/symfony/src/Symfony/Component/Ldap/Adapter/ExtLdap/Connection.php:54/home/karl/code/krixon/symfony/src/Symfony/Component/Ldap/Tests/Adapter/ExtLdap/LdapManagerTest.php:316) Symfony\Component\Ldap\Tests\LdapManagerTest::testLdapAddInvalidEntrySymfony\Component\Ldap\Exception\ConnectionException: Can't contact LDAP server/home/karl/code/krixon/symfony/src/Symfony/Component/Ldap/Adapter/ExtLdap/Connection.php:54/home/karl/code/krixon/symfony/src/Symfony/Component/Ldap/Tests/Adapter/ExtLdap/LdapManagerTest.php:317) Symfony\Component\Ldap\Tests\LdapManagerTest::testLdapUpdateSymfony\Component\Ldap\Exception\ConnectionException: Can't contact LDAP server/home/karl/code/krixon/symfony/src/Symfony/Component/Ldap/Adapter/ExtLdap/Connection.php:54/home/karl/code/krixon/symfony/src/Symfony/Component/Ldap/Tests/Adapter/ExtLdap/LdapManagerTest.php:318) Symfony\Component\Ldap\Tests\LdapManagerTest::testLdapUnboundAddSymfony\Component\Ldap\Exception\ConnectionException: Can't contact LDAP server/home/karl/code/krixon/symfony/src/Symfony/Component/Ldap/Adapter/ExtLdap/Connection.php:54/home/karl/code/krixon/symfony/src/Symfony/Component/Ldap/Tests/Adapter/ExtLdap/LdapManagerTest.php:319) Symfony\Component\Ldap\Tests\LdapManagerTest::testLdapUnboundRemoveSymfony\Component\Ldap\Exception\ConnectionException: Can't contact LDAP server/home/karl/code/krixon/symfony/src/Symfony/Component/Ldap/Adapter/ExtLdap/Connection.php:54/home/karl/code/krixon/symfony/src/Symfony/Component/Ldap/Tests/Adapter/ExtLdap/LdapManagerTest.php:3110) Symfony\Component\Ldap\Tests\LdapManagerTest::testLdapUnboundUpdateSymfony\Component\Ldap\Exception\ConnectionException: Can't contact LDAP server/home/karl/code/krixon/symfony/src/Symfony/Component/Ldap/Adapter/ExtLdap/Connection.php:54/home/karl/code/krixon/symfony/src/Symfony/Component/Ldap/Tests/Adapter/ExtLdap/LdapManagerTest.php:3111) Symfony\Component\Ldap\Tests\LdapManagerTest::testLdapRenameSymfony\Component\Ldap\Exception\ConnectionException: Can't contact LDAP server/home/karl/code/krixon/symfony/src/Symfony/Component/Ldap/Adapter/ExtLdap/Connection.php:54/home/karl/code/krixon/symfony/src/Symfony/Component/Ldap/Tests/Adapter/ExtLdap/LdapManagerTest.php:3112) Symfony\Component\Ldap\Tests\LdapManagerTest::testLdapRenameWithoutRemovingOldRdnSymfony\Component\Ldap\Exception\ConnectionException: Can't contact LDAP server/home/karl/code/krixon/symfony/src/Symfony/Component/Ldap/Adapter/ExtLdap/Connection.php:54/home/karl/code/krixon/symfony/src/Symfony/Component/Ldap/Tests/Adapter/ExtLdap/LdapManagerTest.php:3113) Symfony\Component\Ldap\Tests\LdapClientTest::testLdapClientFunctionalSymfony\Component\Ldap\Exception\ConnectionException: Can't contact LDAP server/home/karl/code/krixon/symfony/src/Symfony/Component/Ldap/Adapter/ExtLdap/Connection.php:54/home/karl/code/krixon/symfony/src/Symfony/Component/Ldap/Ldap.php:38/home/karl/code/krixon/symfony/src/Symfony/Component/Ldap/LdapClient.php:39/home/karl/code/krixon/symfony/src/Symfony/Component/Ldap/Tests/LdapClientTest.php:165--There were 4 failures:1) Symfony\Component\DependencyInjection\Tests\ContainerBuilderTest::testNoClassFromNsSeparatorIdFailed asserting that exception message 'The definition for "\foo" has no class attribute, and appears to reference a class or interface in the global namespace. Leaving out the "class" attribute is only allowed for namespaced classes. Please specify the class attribute explicitly to get rid of this error.' contains 'The definition for "\foo" has no class.'.2) Symfony\Component\HttpFoundation\Tests\JsonResponseTest::testConstructorWithSimpleTypesFailed asserting that two strings are identical.--- Expected+++ Actual@@ @@-'0.1'+'0.10000000000000001'/home/karl/code/krixon/symfony/src/Symfony/Component/HttpFoundation/Tests/JsonResponseTest.php:463) Symfony\Component\HttpFoundation\Tests\JsonResponseTest::testStaticCreateWithSimpleTypesFailed asserting that two strings are identical.--- Expected+++ Actual@@ @@-'0.1'+'0.10000000000000001'/home/karl/code/krixon/symfony/src/Symfony/Component/HttpFoundation/Tests/JsonResponseTest.php:1344) Symfony\Component\HttpFoundation\Tests\ResponseFunctionalTest::testCookie with data set #0 ('cookie_max_age')Failed asserting that string matches format description.--- Expected+++ Actual@@ @@ -Warning: Expiry date cannot have a year greater than 9999 in %scookie_max_age.php on line 10+Fatal error: Uncaught Error: Class 'PHPUnit\Util\ErrorHandler' not found in /home/karl/code/krixon/symfony/vendor/symfony/phpunit-bridge/DeprecationErrorHandler.php:290+Stack trace:+#0 [internal function]: Symfony\Bridge\PhpUnit\DeprecationErrorHandler::Symfony\Bridge\PhpUnit\{closure}(2, 'Expiry date can...', '/home/karl.rixo...', 10, Array)+#1 /home/karl/code/krixon/symfony/src/Symfony/Component/HttpFoundation/Tests/Fixtures/response-functional/cookie_max_age.php(10): setcookie('foo2', 'bar', 253402310800, '/')+#2 {main}+  thrown in /home/karl/code/krixon/symfony/vendor/symfony/phpunit-bridge/DeprecationErrorHandler.php on line 290@@ @@-    [3] => Set-Cookie: foo=bar; expires=Sat, 01-Jan-10000 02:46:40 GMT; Max-Age=%d; path=/+    [3] => Set-Cookie: foo=bar; expires=Sat, 01-Jan-10000 02:46:40 GMT; Max-Age=251872986908; path=//home/karl/code/krixon/symfony/src/Symfony/Component/HttpFoundation/Tests/ResponseFunctionalTest.php:49

@nicolas-grekas
Copy link
Member

Thank you@krixon.

@nicolas-grekasnicolas-grekas merged commitdae704a intosymfony:3.4Jun 19, 2018
nicolas-grekas added a commit that referenced this pull requestJun 19, 2018
…th exactly 0 weeks (krixon)This PR was merged into the 3.4 branch.Discussion----------[Form] Fix error when rendering a DateIntervalType form with exactly 0 weeks| Q             | A| ------------- | ---| Branch?       | 3.4| Bug fix?      | yes| New feature?  | no| BC breaks?    | no| Deprecations? | no| Tests pass?   | yes| Fixed tickets |#27378| License       | MITFixes the issue described in#27378Commits-------dae704aFix#27378: Error when rendering a DateIntervalType form with exactly 0 weeks
@krixonkrixon deleted the dateinterval-array-transformer branchJune 19, 2018 16:19
This was referencedJun 25, 2018
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@nicolas-grekasnicolas-grekasnicolas-grekas approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

3.4

Development

Successfully merging this pull request may close these issues.

3 participants

@krixon@nicolas-grekas@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp