Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Github] Update the pull-request template#27376

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
nicolas-grekas merged 1 commit intosymfony:2.8fromsroze:2.8-is-the-lowest-branch
May 25, 2018

Conversation

@sroze
Copy link
Contributor

@srozesroze commentedMay 25, 2018•
edited
Loading

QA
Branch?2.8
Bug fix?no
New feature?no
BC breaks?no
Deprecations?no
Tests pass?yes
Fixed ticketsø
LicenseMIT
Doc PRø

2.7 is end of life.

@srozesroze changed the base branch frommaster to2.8May 25, 2018 12:05
@srozesroze changed the title[GithUB2.7 is over; 2.8 is the lowest branch for changes[Github] Update the pull-request templateMay 25, 2018
| Q | A
| ------------- | ---
| Branch? | master for features / 2.7 up to 4.0 for bug fixes<!-- see below-->
| Branch? | master for features / 2.8 up to 4.0 for bug fixes<!-- see below-->
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

4.0 can be replaced with4.1 at the same time.

Copy link
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Good point. Changed 😉

@fabpot
Copy link
Member

4.0 is maintained until July 2018, right?

@nicolas-grekasnicolas-grekas added this to the2.8 milestoneMay 25, 2018
@sroze
Copy link
ContributorAuthor

@fabpot sure,the master piece agrees; but if we say "up to" we need to mention the upper branch that isn't master I think. And it's 4.1 now :)

@nicolas-grekas
Copy link
Member

Thank you@sroze.

@nicolas-grekasnicolas-grekas merged commit99327a6 intosymfony:2.8May 25, 2018
nicolas-grekas added a commit that referenced this pull requestMay 25, 2018
This PR was squashed before being merged into the 2.8 branch (closes#27376).Discussion----------[Github] Update the pull-request template| Q             | A| ------------- | ---| Branch?       | 2.8| Bug fix?      | no| New feature?  | no| BC breaks?    | no| Deprecations? | no| Tests pass?   | yes| Fixed tickets | ø| License       | MIT| Doc PR        | ø2.7 is end of life.Commits-------99327a6 [Github] Update the pull-request template
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@nicolas-grekasnicolas-grekasnicolas-grekas approved these changes

@xabbuhxabbuhxabbuh approved these changes

@chalasrchalasrchalasr approved these changes

+2 more reviewers

@jvasseurjvasseurjvasseur left review comments

@ogizanagiogizanagiogizanagi approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Projects

None yet

Milestone

2.8

Development

Successfully merging this pull request may close these issues.

8 participants

@sroze@fabpot@nicolas-grekas@jvasseur@xabbuh@ogizanagi@chalasr@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp