Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[DI] Fix bad exception on uninitialized references to non-shared services#27364
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
stof approved these changesMay 24, 2018
c6bdc5a to8bba68fComparechalasr approved these changesMay 24, 2018
Contributor
curry684 commentedMay 24, 2018
Seems fine to me 👍 I'll rerun the offending tests to confirm when it's merged. |
ogizanagi approved these changesMay 24, 2018
nicolas-grekas added a commit that referenced this pull requestMay 25, 2018
…shared services (nicolas-grekas)This PR was merged into the 3.4 branch.Discussion----------[DI] Fix bad exception on uninitialized references to non-shared services| Q | A| ------------- | ---| Branch? | 3.4| Bug fix? | yes| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets |#27360| License | MIT| Doc PR | -This restriction is unneeded complexity that prevents legit use cases (see linked issue#27360).Commits-------8bba68f [DI] Fix bad exception on uninitialized references to non-shared services
Merged
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This restriction is unneeded complexity that prevents legit use cases (see linked issue#27360).