Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Cache] memcache connect should not add duplicate entries on sequential calls#27318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
nicolas-grekas commentedMay 29, 2018
@palex-fpt why did you close ? |
palex-fpt commentedMay 29, 2018
oops. I did not notice it was added to 3.4 milestone. I thought it should be based on 3.4 branch and resubmit it. |
chalasr commentedMay 29, 2018
@palex-fpt no need for a new PR, we can switch the target branch while merging, but you can also do it on your sidehttps://blog.github.com/2016-08-15-change-the-base-branch-of-a-pull-request/ (and rebase). |
…ntries on sequential calls
nicolas-grekas commentedJun 4, 2018
Thank you@palex-fpt. |
…on sequential calls (Aleksey Prilipko)This PR was submitted for the 3.3 branch but it was merged into the 3.4 branch instead (closes#27318).Discussion----------[Cache] memcache connect should not add duplicate entries on sequential calls| Q | A| ------------- | ---| Branch? | 3.4 (be careful when merging)| Bug fix? | yes| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | no| Fixed tickets |#27299| License | MITMemcachedCache::createConnection adds server to list of servers on every call. But resets this list only when it is not empty and does not match configured list.This leads to follow: after first call list contains correct entry. After second it has server entry twice. After third it clears list and set it with correct value.With combination of libmemcached bug (segfault on adding server after reset nonempty list) it makes impossible to use MemcachedCache::createConnection to create persistent connections.Commits-------af06990 bug#27299 [Cache] memcache connect should not add duplicate entries on sequential calls
Uh oh!
There was an error while loading.Please reload this page.
MemcachedCache::createConnection adds server to list of servers on every call. But resets this list only when it is not empty and does not match configured list.
This leads to follow: after first call list contains correct entry. After second it has server entry twice. After third it clears list and set it with correct value.
With combination of libmemcached bug (segfault on adding server after reset nonempty list) it makes impossible to use MemcachedCache::createConnection to create persistent connections.