Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Messenger] Re-introduce wrapped message configuration (with fix)#27182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

@sroze
Copy link
Contributor

QA
Branch?4.1
Bug fix?no
New feature?yes
BC breaks?no
Deprecations?no
Tests pass?yes
Fixed tickets#26945
LicenseMIT
Doc PRø

The pull request was merged before beta1, but because it introduced a bug, it has been reverted. This adds back the merged PR but pushes a fix for the found bug.

@srozesrozeforce-pushed there-introduce-wrapped-message-configuration branch from5a9d672 toad01c29CompareMay 7, 2018 16:08
@srozesroze added this to the4.1 milestoneMay 7, 2018
@srozesroze requested a review fromogizanagiMay 7, 2018 16:08
@kbond
Copy link
Member

What exactly was the bug?

@ogizanagi
Copy link
Contributor

The original envelope was not properly passed along the whole middleware stack when calling$next($message), so items were vanished in between.
This fixes it and also allows altering the message and the envelope items through middlewares.

kbond reacted with thumbs up emoji

@ogizanagi
Copy link
Contributor

I've pushed another commit tosroze#6 for the TraceableBus which misses a small update.

@srozesrozeforce-pushed there-introduce-wrapped-message-configuration branch from837c483 tob879e1dCompareMay 8, 2018 14:52
srozeand others added3 commitsMay 9, 2018 15:46
@srozesrozeforce-pushed there-introduce-wrapped-message-configuration branch fromb879e1d to21e49d2CompareMay 9, 2018 14:48
@sroze
Copy link
ContributorAuthor

Merging as we found and fixed the bug that was almost to bug in beta1.

@sroze
Copy link
ContributorAuthor

Thank you@ogizanagi.

@srozesroze merged commit21e49d2 intosymfony:4.1May 9, 2018
sroze added a commit that referenced this pull requestMay 9, 2018
… (with fix) (sroze, ogizanagi)This PR was merged into the 4.1 branch.Discussion----------[Messenger] Re-introduce wrapped message configuration (with fix)| Q             | A| ------------- | ---| Branch?       | 4.1| Bug fix?      | no| New feature?  | yes| BC breaks?    | no| Deprecations? | no| Tests pass?   | yes| Fixed tickets |#26945| License       | MIT| Doc PR        | øThe pull request was merged before beta1, but because it introduced a bug, it has been reverted. This adds back the merged PR but pushes a fix for the found bug.Commits-------21e49d2 [Messenger] Fix TraceableBus with envelope599f32c Ensure the envelope is passed back and can be altered Ensure that the middlewares can also update the message within the envelope7c33cb2 feature#26945 [Messenger] Support configuring messages when dispatching (ogizanagi)
@srozesroze deleted the re-introduce-wrapped-message-configuration branchMay 9, 2018 18:54
@fabpotfabpot mentioned this pull requestMay 21, 2018
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

1 more reviewer

@ogizanagiogizanagiogizanagi approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Projects

None yet

Milestone

4.1

Development

Successfully merging this pull request may close these issues.

4 participants

@sroze@kbond@ogizanagi@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp