Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[FrameworkBundle][Messenger] Remove convention-based service id generation for buses#27162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fabpot merged 1 commit intosymfony:masterfromnicolas-grekas:messenger-explicit
May 7, 2018

Conversation

@nicolas-grekas
Copy link
Member

@nicolas-grekasnicolas-grekas commentedMay 4, 2018
edited
Loading

QA
Branch?master
Bug fix?yes (DX)
New feature?no
BC breaks?no
Deprecations?no
Tests pass?yes
Fixed tickets-
LicenseMIT
Doc PR-

Service ids for buses are user facing ids: pplwill have to deal with them when wiring their services.
Like for cache pools, we should ask ppl to declare them using full identifiers, instead of having a convention-based way to turn a name into and id (which is something nobody will be able to remember at some point.)

ro0NL, linaori, and Tobion reacted with thumbs up emojijvasseur reacted with confused emoji
@fabpot
Copy link
Member

Thank you@nicolas-grekas.

@fabpotfabpot merged commitc7a0045 intosymfony:masterMay 7, 2018
fabpot added a commit that referenced this pull requestMay 7, 2018
…ce id generation for buses (nicolas-grekas)This PR was merged into the 4.1-dev branch.Discussion----------[FrameworkBundle][Messenger] Remove convention-based service id generation for buses| Q             | A| ------------- | ---| Branch?       | master| Bug fix?      | yes (DX)| New feature?  | no| BC breaks?    | no| Deprecations? | no| Tests pass?   | yes| Fixed tickets | -| License       | MIT| Doc PR        | -Service ids for buses are user facing ids: ppl *will* have to deal with them when wiring their services.Like for cache pools, we should ask ppl to declare them using full identifiers, instead of having a convention-based way to turn a name into and id (which is something nobody will be able to remember at some point.)Commits-------c7a0045 [FrameworkBundle][Messenger] Remove convention-based service id generation for buses
fabpot added a commit that referenced this pull requestMay 9, 2018
This PR was merged into the 4.1 branch.Discussion----------[Messenger] Fix default bus name| Q             | A| ------------- | ---| Branch?       | 4.1 <!-- see below -->| Bug fix?      | yesish| New feature?  | no <!-- don't forget to update src/**/CHANGELOG.md files -->| BC breaks?    | no     <!-- seehttps://symfony.com/bc -->| Deprecations? | no <!-- don't forget to update UPGRADE-*.md and src/**/CHANGELOG.md files -->| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->| Fixed tickets |#27162   <!-- #-prefixed issue number(s), if any -->| License       | MIT| Doc PR        | N/AAfter#27162, the default bus name configured automatically should use a full service id too, otherwise we currently get a `default` service id, no namespace identifier, which is the default bus.Commits-------fa9b984 [Messenger] Fix default bus name
weaverryan added a commit to symfony/symfony-docs that referenced this pull requestMay 9, 2018
This PR was submitted for the master branch but it was squashed and merged into the 4.1 branch instead (closes#9727).Discussion----------[Messenger] Update the messenger documentation- [x]Fixes#9641 with the middleware configuration.- [x]Fixes#9617 with the multiple bus configuration.- [x] Change adapters to transports (waiting merge:symfony/symfony#27129)- [x] middlewares config entry is renamed middleware (symfony/symfony#27177)- [x] in the config, message buses names are the full service id you'll use (symfony/symfony#27162)- [x] Add TransportInterface as first class citizen sender+receiver (symfony/symfony#27164)Commits-------c3c3528 Few updates following review64bfd75 Change wording and don't use `.`-based services so it's just clearere1f3b5a Fix the formating of the method name9b7b85f Update the example of using multiple buses to use DI's `bind`sc76b2c2 Uses the full service name when configuring the buses from the YAML configuration2409798 Middleware does not have a plurala20286d Add a note about the symfony serializer pack10f46eb Introduce the `TransportInterface`ef70bc0 Add a documentation about the middlewares3ff8cfe Add multiple buses configuration and type-hint examplea4bc592 Rename the adapters to transport
@nicolas-grekasnicolas-grekas deleted the messenger-explicit branchMay 16, 2018 14:51
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@fabpotfabpotfabpot approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

4.1

Development

Successfully merging this pull request may close these issues.

3 participants

@nicolas-grekas@fabpot@carsonbot

[8]ページ先頭

©2009-2025 Movatter.jp