Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Cache] fix logic for fetching tag versions on TagAwareAdapter#27158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
| } | ||
| if (!isset($this->knownTagVersions[$tag])) { | ||
| $fetchTagVersions =true; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
That's the correct fix thanks. I'd just suggest to keep the previous single "if" and add this line in it.
nicolas-grekas commentedMay 5, 2018
Thank you@dmaicher. |
…pter (dmaicher)This PR was squashed before being merged into the 3.4 branch (closes#27158).Discussion----------[Cache] fix logic for fetching tag versions on TagAwareAdapter| Q | A| ------------- | ---| Branch? | 3.4| Bug fix? | yes| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets |#27147| License | MIT| Doc PR | -There was a problem introduced in#27007 which breaks tag invalidation.From what I can see there were some cases when the actual tag versions were never fetched from the tags pool and version=0 was used.@nicolas-grekas this is my attempt of understanding the logic within `TagAwareAdapter`. Please have a look if this makes sense to you 😉Commits-------d3790ca [Cache] fix logic for fetching tag versions on TagAwareAdapter
andrerom commentedMay 11, 2018
@nicolas-grekas Any chance getting a small 3.4 release out? |
There was a problem introduced in#27007 which breaks tag invalidation.
From what I can see there were some cases when the actual tag versions were never fetched from the tags pool and version=0 was used.
@nicolas-grekas this is my attempt of understanding the logic within
TagAwareAdapter. Please have a look if this makes sense to you 😉