Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Messenger] Rename Adapters to Transports#27129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

@sroze
Copy link
Contributor

QA
Branch?master
Bug fix?no
New feature?no
BC breaks?no
Deprecations?no
Tests pass?yes
Fixed ticketsø
LicenseMIT
Doc PRø

Last of our tasks on the "plan to beta", renaming "adapters" to "transports". This is a term that makes more sense and is commonly used within the "queue community".

@srozesroze requested a review fromweaverryanMay 2, 2018 19:54
@srozesrozeforce-pushed therename-messenger-adapters-to-transports branch 2 times, most recently from3220182 to68208f3CompareMay 2, 2018 20:04
Copy link
Contributor

@ogizanagiogizanagi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

There are still some occurrences ofadapter in the component. Does it make sense to keep those? It doesn't disturb me at those places, but asking anyway :)

screenshot 2018-05-02 a 22 12 56

@Tobion
Copy link
Contributor

Tobion commentedMay 2, 2018•
edited
Loading

What I also found is that namespaces of interfaces and implementations are not consistent.
https://github.com/symfony/symfony/blob/master/src/Symfony/Component/Messenger/MiddlewareInterface.php is in the messener root. But the implementations are in a sub-namespacehttps://github.com/symfony/symfony/tree/master/src/Symfony/Component/Messenger/Middleware
But the implemtations ofhttps://github.com/symfony/symfony/blob/master/src/Symfony/Component/Messenger/HandlerLocatorInterface.php are also in the root.
https://github.com/symfony/symfony/blob/master/src/Symfony/Component/Messenger/Handler/MessageHandlerInterface.php is not in the root and the implementation neither.

sroze reacted with thumbs up emoji

@Tobion
Copy link
Contributor

Tobion commentedMay 2, 2018•
edited
Loading

So I'd propose

  1. move the bus stuff to Symfony\Component\Messenger\Bus\
  2. move handler locators to Symfony\Component\Messenger\Handler\Locator\
  3. move Symfony\Component\Messenger\MiddlewareInterface to Symfony\Component\Messenger\Middleware\MiddlewareInterface

@nicolas-grekasnicolas-grekas added this to the4.1 milestoneMay 2, 2018
@ogizanagi
Copy link
Contributor

ogizanagi commentedMay 3, 2018•
edited
Loading

I agree with@Tobion . But I'd keepMessageBus andMessageBusInterface root as the main component entry point. It seems consistent with what we did with other components.

sroze reacted with thumbs up emoji

@srozesrozeforce-pushed therename-messenger-adapters-to-transports branch from7d8a7f1 to2c7730eCompareMay 3, 2018 07:52
@sroze
Copy link
ContributorAuthor

Good catch@Tobion, it was the right time to move them. I've moved the handler and middleware ones, kept the Bus one at the root like we do on other bundles like the Serializer.

Copy link
Member

@weaverryanweaverryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

👍 adapters -> transports & the other renamings.

@nicolas-grekasnicolas-grekasforce-pushed therename-messenger-adapters-to-transports branch from2c7730e to13b7475CompareMay 4, 2018 00:10
@nicolas-grekas
Copy link
Member

Thank you@sroze.

@nicolas-grekasnicolas-grekas merged commit13b7475 intosymfony:masterMay 4, 2018
nicolas-grekas added a commit that referenced this pull requestMay 4, 2018
This PR was squashed before being merged into the 4.1-dev branch (closes#27129).Discussion----------[Messenger] Rename Adapters to Transports| Q             | A| ------------- | ---| Branch?       | master| Bug fix?      | no| New feature?  | no| BC breaks?    | no| Deprecations? | no| Tests pass?   | yes| Fixed tickets | ø| License       | MIT| Doc PR        | øLast of our tasks on the "plan to beta", renaming "adapters" to "transports". This is a term that makes more sense and is commonly used within the "queue community".Commits-------13b7475 [Messenger] Rename Adapters to Transports
<argumenttype="collection" />
</service>

<!-- Adapters-->
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Does this line also should be renamed?

@srozesroze deleted the rename-messenger-adapters-to-transports branchMay 4, 2018 07:40
weaverryan added a commit to symfony/symfony-docs that referenced this pull requestMay 9, 2018
This PR was submitted for the master branch but it was squashed and merged into the 4.1 branch instead (closes#9727).Discussion----------[Messenger] Update the messenger documentation- [x]Fixes#9641 with the middleware configuration.- [x]Fixes#9617 with the multiple bus configuration.- [x] Change adapters to transports (waiting merge:symfony/symfony#27129)- [x] middlewares config entry is renamed middleware (symfony/symfony#27177)- [x] in the config, message buses names are the full service id you'll use (symfony/symfony#27162)- [x] Add TransportInterface as first class citizen sender+receiver (symfony/symfony#27164)Commits-------c3c3528 Few updates following review64bfd75 Change wording and don't use `.`-based services so it's just clearere1f3b5a Fix the formating of the method name9b7b85f Update the example of using multiple buses to use DI's `bind`sc76b2c2 Uses the full service name when configuring the buses from the YAML configuration2409798 Middleware does not have a plurala20286d Add a note about the symfony serializer pack10f46eb Introduce the `TransportInterface`ef70bc0 Add a documentation about the middlewares3ff8cfe Add multiple buses configuration and type-hint examplea4bc592 Rename the adapters to transport
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@weaverryanweaverryanweaverryan approved these changes

@chalasrchalasrchalasr approved these changes

+3 more reviewers

@KocKocKoc left review comments

@TobionTobionTobion approved these changes

@ogizanagiogizanagiogizanagi approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Projects

None yet

Milestone

4.1

Development

Successfully merging this pull request may close these issues.

8 participants

@sroze@Tobion@ogizanagi@nicolas-grekas@weaverryan@Koc@chalasr@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp