Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[DX] Redirect to proper Symfony version documentation#27104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fabpot merged 1 commit intosymfony:masterfromnoniagriconomie:patch-1
May 3, 2018

Conversation

@noniagriconomie
Copy link
Contributor

@noniagriconomienoniagriconomie commentedApr 30, 2018•
edited
Loading

QA
Branch?3.4
Bug fix?no
New feature?no
BC breaks?no
Deprecations?no
Tests pass?yes
Fixed ticketsnone
LicenseMIT
Doc PR

Just a small improvement
I think this can make some dev target the right documentation instead of reading an other version that the one they are developing on

EDIT: I do not know if including the constant directly is the good choice, or it is better to add a global symfony version collector?

@nicolas-grekasnicolas-grekas added this to the3.4 milestoneApr 30, 2018
@noniagriconomienoniagriconomie changed the titleRedirect to proper Symfony version documentation[DX] Redirect to proper Symfony version documentationApr 30, 2018
@noniagriconomie
Copy link
ContributorAuthor

@fabpot understood, target blank removed

@lyrixx
Copy link
Member

The target branch is not good. It should be either 2.7 (bug fix) or master (new feature).
I don't know what is it though

@noniagriconomie
Copy link
ContributorAuthor

noniagriconomie commentedMay 2, 2018•
edited
Loading

This code does not exists on 2.x
And as 3.4 is an lts and it is code on dev only, i think it should be discussed/accepted IMO
What do you think?

lyrixx reacted with thumbs up emoji

@fabpotfabpot changed the base branch from3.4 tomasterMay 3, 2018 06:28
Copy link
Member

@fabpotfabpot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

for master

@fabpot
Copy link
Member

Thank you@noniagriconomie.

@fabpotfabpot merged commitd611160 intosymfony:masterMay 3, 2018
fabpot added a commit that referenced this pull requestMay 3, 2018
…(noniagriconomie)This PR was squashed before being merged into the 4.1-dev branch (closes#27104).Discussion----------[DX] Redirect to proper Symfony version documentation| Q             | A| ------------- | ---| Branch?       | 3.4| Bug fix?      | no| New feature?  | no| BC breaks?    | no| Deprecations? | no| Tests pass?   | yes| Fixed tickets | none| License       | MIT| Doc PR        |Just a small improvementI think this can make some dev target the right documentation instead of reading an other version that the one they are developing onEDIT: I do not know if including the constant directly is the good choice, or it is better to add a global symfony version collector?Commits-------d611160 [DX] Redirect to proper Symfony version documentation
@noniagriconomienoniagriconomie deleted the patch-1 branchMay 3, 2018 10:23
@fabpotfabpot mentioned this pull requestMay 7, 2018
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@fabpotfabpotfabpot approved these changes

@dunglasdunglasdunglas approved these changes

+1 more reviewer

@srozesrozesroze approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Projects

None yet

Milestone

3.4

Development

Successfully merging this pull request may close these issues.

7 participants

@noniagriconomie@lyrixx@fabpot@dunglas@sroze@nicolas-grekas@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp