Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Debug] Fixed the formatPath when a custom fileLinkFormat is defined#27098

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed
lyrixx wants to merge1 commit intosymfony:3.4fromlyrixx:debug-parse-error-link

Conversation

@lyrixx
Copy link
Member

@lyrixxlyrixx commentedApr 30, 2018•
edited
Loading

QA
Branch?3.4
Bug fix?yes
New feature?no
BC breaks?no
Deprecations?no
Tests pass?yes
Fixed tickets#27097
LicenseMIT
Doc PR

@lyrixxlyrixxforce-pushed thedebug-parse-error-link branch from6a3e9d1 to47bdc7aCompareApril 30, 2018 10:28
@lyrixxlyrixx changed the base branch from2.7 to2.8April 30, 2018 10:28
@lyrixxlyrixxforce-pushed thedebug-parse-error-link branch from47bdc7a to6983b28CompareApril 30, 2018 10:34
@lyrixxlyrixx changed the base branch from2.8 to2.7April 30, 2018 10:34
@lyrixxlyrixx changed the title[Debug] Fixed the formatPath when a custom fileLinkFormat is definedWIP - [Debug] Fixed the formatPath when a custom fileLinkFormat is definedApr 30, 2018
@lyrixxlyrixxforce-pushed thedebug-parse-error-link branch from6983b28 toec94593CompareApril 30, 2018 10:47
@lyrixxlyrixx changed the titleWIP - [Debug] Fixed the formatPath when a custom fileLinkFormat is defined[Debug] Fixed the formatPath when a custom fileLinkFormat is definedApr 30, 2018
@nicolas-grekas
Copy link
Member

There is#27074 pending on the topic, but I'm not sure it fixes your issue actually, can you try it?
I don't think the special format has been introduced in 2.7, could you please check?
Maybe my PR should somehow call setFileLinkFormat()?

@lyrixxlyrixxforce-pushed thedebug-parse-error-link branch fromec94593 to2c7fe42CompareApril 30, 2018 12:39
@lyrixx
Copy link
MemberAuthor

lyrixx commentedApr 30, 2018•
edited
Loading

There is#27074 pending on the topic, but I'm not sure it fixes your issue actually, can you try it?

  1. It does not solves my issue
  2. It does not work: I had to hardcode my$fileLinkFormat to work on my PR

I don't think the special format has been introduced in 2.7, could you please check?

Indeed. I updated the base branch (3.4)

@lyrixxlyrixx changed the base branch from2.7 to3.4April 30, 2018 12:41
@nicolas-grekasnicolas-grekas added this to the3.4 milestoneApr 30, 2018
@nicolas-grekas
Copy link
Member

commit borrowed in#27074

@lyrixxlyrixx deleted the debug-parse-error-link branchMay 3, 2018 08:38
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Projects

None yet

Milestone

3.4

Development

Successfully merging this pull request may close these issues.

3 participants

@lyrixx@nicolas-grekas@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp