While working on another PR (to come), I noticed that the workflow component is using the word "reset" for something that is consistently called "clear" in the rest of the code base (emptying the state of an object) - and also that "reset" is consistently used for setting an object back to its initial state (which might not be the empty state, contrary to what clear does).

Here is a PR fixing this inconsistency. Should be on 4.1 so that we won't have to deal with another BC layer in 4.2.

[Workflow] "clear()" instead of "reset()"

858fabb

nicolas-grekas added this to the4.1 milestone

Apr 30, 2018

fabpot approved these changes

Apr 30, 2018

View reviewed changes

carsonbot added the Status: Reviewed label

Apr 30, 2018

Copy link

Member

fabpot commentedApr 30, 2018

Thank you@nicolas-grekas.

fabpot merged commit858fabb intosymfony:master

Apr 30, 2018

fabpot added a commit that referenced this pull request

Apr 30, 2018

feature#27092[Workflow] "clear()" instead of "reset()" (nicolas-gre…

5a5b925

…kas)This PR was merged into the 4.1-dev branch.Discussion----------[Workflow] "clear()" instead of "reset()"| Q             | A| ------------- | ---| Branch?       | master| Bug fix?      | no| New feature?  | no| BC breaks?    | no| Deprecations? | yes| Tests pass?   | yes| Fixed tickets | -| License       | MIT| Doc PR        | -While working on another PR (to come), I noticed that the workflow component is using the word "reset" for something that is consistently called "clear" in the rest of the code base (emptying the state of an object) - and also that "reset" is consistently used for setting an object back to its initial state (which might not be the empty state, contrary to what clear does).Here is a PR fixing this inconsistency. Should be on 4.1 so that we won't have to deal with another BC layer in 4.2.Commits-------858fabb [Workflow] "clear()" instead of "reset()"