Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[DI][Routing] Allow invokable objects to be used as PHP-DSL loaders#27065

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fabpot merged 1 commit intosymfony:masterfromaurimasniekis:php-config-callable
Apr 27, 2018
Merged

[DI][Routing] Allow invokable objects to be used as PHP-DSL loaders#27065

fabpot merged 1 commit intosymfony:masterfromaurimasniekis:php-config-callable
Apr 27, 2018

Conversation

@aurimasniekis
Copy link
Contributor

@aurimasniekisaurimasniekis commentedApr 26, 2018•
edited by nicolas-grekas
Loading

QA
Branch?master
Bug fix?no
New feature?no
BC breaks?no
Deprecations?no
Tests pass?yes
Fixed tickets#26583,#25630
LicenseMIT
Doc PRnone

Changed DI/Router PHPFileLoader to check is_object && is_callable instead of instance of Closure

@nicolas-grekas
Copy link
Member

Thanks :)
Would you mind adding a test case please?

@nicolas-grekasnicolas-grekas added this to the4.1 milestoneApr 26, 2018
@aurimasniekis
Copy link
ContributorAuthor

aurimasniekis commentedApr 26, 2018•
edited
Loading

For which case? When tried to supply array callback? Because when array would be passed nothing will happen so I don't know what to test against.

@nicolas-grekas
Copy link
Member

For the case when you pass an invokable object.

@aurimasniekis
Copy link
ContributorAuthor

Oh right forgot about this simple case 😊

@aurimasniekis
Copy link
ContributorAuthor

@nicolas-grekas I don't know about Routing test I did not want to introduce copied test case so I just extended existing test case there.

@nicolas-grekasnicolas-grekas changed the title#26583 Changed DI/Router PHPFileLoader to check is_object && is_callable instead of instance of Closure[DI][Routing] Allow invokable objects to be used as PHP-DSL loadersApr 26, 2018
@@ -0,0 +1,10 @@

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

extra unneeded line

Copy link
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

@fabpot
Copy link
Member

Thank you@aurimasniekis.

@fabpotfabpot merged commit662ff7e intosymfony:masterApr 27, 2018
fabpot added a commit that referenced this pull requestApr 27, 2018
…P-DSL loaders (aurimasniekis)This PR was squashed before being merged into the 4.1-dev branch (closes#27065).Discussion----------[DI][Routing] Allow invokable objects to be used as PHP-DSL loaders| Q             | A| ------------- | ---| Branch?       | master| Bug fix?      | no| New feature?  | no| BC breaks?    | no| Deprecations? | no| Tests pass?   | yes| Fixed tickets |#26583,#25630| License       | MIT| Doc PR        | noneChanged DI/Router PHPFileLoader to check is_object && is_callable instead of instance of ClosureCommits-------662ff7e [DI][Routing] Allow invokable objects to be used as PHP-DSL loaders
@fabpotfabpot mentioned this pull requestMay 7, 2018
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@fabpotfabpotfabpot approved these changes

@nicolas-grekasnicolas-grekasnicolas-grekas approved these changes

+1 more reviewer

@TobionTobionTobion approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Projects

None yet

Milestone

4.1

Development

Successfully merging this pull request may close these issues.

5 participants

@aurimasniekis@nicolas-grekas@fabpot@Tobion@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp