Is this still needed given that#26332 was merged?

This follow the last, this PR add a 'help_attr', like 'label_attr' for exemple. That permit to configure the 'help' entry.

@mpiot LGTM, can you please rebase here?

@xabbuh yes, I do that on Monday ;-) And I'll see to add a part about that in the doc

We need to update the constraints for the Form component in thecomposer.json file of the Twig bridge to conflict with releases before 4.2.

Mmm, sorry I don't really know what to do :-/
Change the:
"require-dev": {
...
"symfony/form": "^4.1",
...
},
"conflict": {
...
"symfony/form": "^4.1",
...
},

I replace all 4.1 per ... ? 4.2 ? But I need to declare somewhere the version change ?

And I need to do the same in the Twig Bridge ?

I'm so sorry, I don't really know how it works.

@xabbuh Thanks

I try to understand errors with deps=high. On my machine when I do something like:

cd src/Symfony/Bundle/FrameworkBundle/composer update --no-progress --no-suggest --ansiphpunit --exclude-group tty,benchmark,intl-data

And tests are OK, I don't see the difference with Travis, because I use the same commands as in the travis test.

Edit: I try to add the form version requirement in the FrameworkBundle too

@mpiot This is a bit tricky. We use Travis to ensure that 4.1 versions of components work with 4.2 dependencies. The form theme tests are not very flexible as they mainly just compare the rendered HTML. I try to find a way to relax them a bit.

I've not reviewed this PR but I've spotted a merge commit in the history.@mpiot Can you rebase to get rid of it (as PR with merge commits cannot be merged)? Thank you.

@xabbuh thanks, so there's no way to pass the tests right now?

@mpiot I try to look into it tonight.

If I don't miss anything here, tests would pass just when we merge this into themaster branch. Wecould skip the new tests in case the Form component is not available in a compatible version, but that would only be needed for this PR. Afterwards, FrameworkBundle as well as TwigBridge will conflict with these versions of the Form component. So IMO not worth it to me and I vote for just merging as is.

Thank you for the time you spent watching this :-)

I'll write the doc asap :-)

Thank you@mpiot.

@mpiot FYI,@nicolas-grekas helped me to spot why the tests where failing (I moved the test method from the Form component to the concrete subclasses in FrameworkBundle and TwigBridge to fix it).

@xabbuh Thank you for this feedback, always important to know what was wrong :-)