NotificationsYou must be signed in to change notification settings
Fork9.7k
Star30.8k

[HttpFoundation] Fixes to new HeaderUtils class#27019

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

fabpot merged 1 commit intosymfony:masterfromc960657:header-utils-fixes

Apr 27, 2018

Merged

[HttpFoundation] Fixes to new HeaderUtils class#27019

fabpot merged 1 commit intosymfony:masterfromc960657:header-utils-fixes

Apr 27, 2018

Conversation

Copy link

Contributor

c960657 commentedApr 23, 2018

Q	A
Branch?	master
Bug fix?	yes
New feature?	no
BC breaks?	no
Deprecations?	no
Tests pass?	yes
Fixed tickets
License	MIT
Doc PR

A follow-up to#24699 with a few code and documentation fixes for post-merge review comments by@stof.

carsonbot added Status: Needs Review HttpFoundation Bug labels

Apr 23, 2018

c960657 mentioned this pull request

Apr 23, 2018

[HttpFoundation] Add HeaderUtils class#24699

Merged

Copy link

Member

javiereguiluz commentedApr 24, 2018

In the PHPdoc ofjoinAssoc() there are some minor issue that should be fixed too:

... is joined ... ->... are joined ...
The result of the example ('foo=bar, baz, baz="a b c"') should be'foo=abc, bar, baz="a b c"'

Thanks!

nicolas-grekas mentioned this pull request

Apr 24, 2018

[RFC] Rename some HeaderUtils methods#27026

Closed

nicolas-grekas added this to the4.1 milestone

Apr 24, 2018

carsonbot removed the Status: Needs Review label

Apr 27, 2018

fabpot approved these changes

Apr 27, 2018

View reviewed changes

carsonbot added the Status: Reviewed label

Apr 27, 2018

[HttpFoundation] Fixes to new HeaderUtils class

d7c3c79

fabpot force-pushed theheader-utils-fixes branch froma05455f tod7c3c79Compare

April 27, 2018 09:35

Copy link

Member

fabpot commentedApr 27, 2018

Thank you@c960657.

fabpot merged commitd7c3c79 intosymfony:master

Apr 27, 2018

fabpot added a commit that referenced this pull request

Apr 27, 2018

minor#27019[HttpFoundation] Fixes to new HeaderUtils class (c960657)

00ca74e

This PR was squashed before being merged into the 4.1-dev branch (closes#27019).Discussion----------[HttpFoundation] Fixes to new HeaderUtils class| Q             | A| ------------- | ---| Branch?       | master| Bug fix?      | yes| New feature?  | no| BC breaks?    | no| Deprecations? | no| Tests pass?   | yes| Fixed tickets || License       | MIT| Doc PR        |A follow-up to#24699 with a few code and documentation fixes for post-merge review comments by@stof.Commits-------d7c3c79 [HttpFoundation] Fixes to new HeaderUtils class