Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[WebProfilerBundle] Display uploaded files in the profiler#26946
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
chapterjason commentedApr 21, 2018 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Looks awesome, as I watched in the |
| <thscope="col">File Name</th> | ||
| <thscope="col">MIME Type</th> | ||
| <thscope="col text-right">Size (bytes)</th> | ||
| <thscope="col">Temporary Location</th> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
is this useful info? afaik, the temp file is gone when this is displayed, isn't it?
chapterjasonJun 19, 2018 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
You're right.
The file will be deleted from the temporary directory at the end of the request if it has not been moved away or renamed.
http://php.net/manual/en/features.file-upload.post-method.php
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
@javiereguiluz Can you remove this column?
| <thscope="col">File Name</th> | ||
| <thscope="col">MIME Type</th> | ||
| <thscope="col text-right">Size (bytes)</th> | ||
| <thscope="col">Temporary Location</th> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
@javiereguiluz Can you remove this column?
fabpot commentedJun 25, 2018
Thank you@javiereguiluz. |
…iler (javiereguiluz)This PR was squashed before being merged into the 4.2-dev branch (closes#26946).Discussion----------[WebProfilerBundle] Display uploaded files in the profiler| Q | A| ------------- | ---| Branch? | master| Bug fix? | no| New feature? | yes| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets |#26926| License | MIT| Doc PR | -Note: I wanted to use the VarDumper to display the table information (as we do in the rest of tables) but I had lots of problems and I just wanted to create a proof of concept for the feature to see if we like it.Commits-------3f6f75b [WebProfilerBundle] Display uploaded files in the profiler
xabbuh commentedJun 26, 2018
Wouldn't it make sense to also display the error (possibly human readable) if any occurred during uploading? |
Uh oh!
There was an error while loading.Please reload this page.
Note: I wanted to use the VarDumper to display the table information (as we do in the rest of tables) but I had lots of problems and I just wanted to create a proof of concept for the feature to see if we like it.