Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[Form] Fixed trimming choice values#26932

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fabpot merged 1 commit intosymfony:2.7fromHeahDude:choice-trim
Apr 16, 2018
Merged

Conversation

@HeahDude
Copy link
Contributor

@HeahDudeHeahDude commentedApr 15, 2018
edited
Loading

QA
Branch?2.7
Bug fix?yes
New feature?no
BC breaks?no
Deprecations?no
Tests pass?yes
Fixed tickets#24247,#24712
LicenseMIT
Doc PRsymfony/symfony-docs#9598

Follows#24712 discussion.

@HeahDude
Copy link
ContributorAuthor

Change documented heresymfony/symfony-docs#9598.

@HeahDudeHeahDudeforce-pushed thechoice-trim branch 3 times, most recently from81b8bbf to22f3851CompareApril 15, 2018 08:07
@HeahDudeHeahDude changed the titleFixed trimming choice values[Form] Fixed trimming choice valuesApr 15, 2018
@HeahDudeHeahDude changed the base branch frommaster to2.7April 15, 2018 08:09
Copy link
Member

@nicolas-grekasnicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks, just one test case to add and good for me

@nicolas-grekas
Copy link
Member

Just to reduce the BC breaking potential: what about trying the trimmed value when the non trimmed one doesn't match?

@nicolas-grekasnicolas-grekas added this to the2.7 milestoneApr 15, 2018
@HeahDude
Copy link
ContributorAuthor

I've added a test that covers submitting a value with a white space.

I don't think we should have a double check that add some overhead in two different transformers, it would mean we may should care of deprecating that behavior in master, adding even more overhead.

You convinced me that this was a bug fix :), then I'm not in favor of having an ambiguous behavior about a match that should not be expected. It is not even possible to try to submit invalid values using a Form API from Browser Kit when playing in tests.

What about not caring about this :), but taking care of fixing the docs should be enough, WDYT?

@fabpot
Copy link
Member

Thank you@HeahDude.

@fabpotfabpot merged commit00cdf5e intosymfony:2.7Apr 16, 2018
fabpot added a commit that referenced this pull requestApr 16, 2018
This PR was merged into the 2.7 branch.Discussion----------[Form] Fixed trimming choice values| Q             | A| ------------- | ---| Branch?       | 2.7| Bug fix?      | yes| New feature?  | no| BC breaks?    | no| Deprecations? | no| Tests pass?   | yes| Fixed tickets |#24247,#24712| License       | MIT| Doc PR        |symfony/symfony-docs#9598Follows#24712 discussion.Commits-------00cdf5e [Form] Fixed trimming choice values
@HeahDudeHeahDude deleted the choice-trim branchApril 17, 2018 07:27
This was referencedApr 27, 2018
wouterj added a commit to symfony/symfony-docs that referenced this pull requestMay 8, 2018
…uiluz)This PR was merged into the 2.7 branch.Discussion----------[Form] Fixed ChoiceType trim optionRefsymfony/symfony#26932.Commits-------2dd6c56 fixup typo360066d fixup option links6631665 fixup@xabbuh's comment proper choice type trim file8bfa059 Rewordbbca3b0 [Form] Fixed ChoiceType trim option
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@fabpotfabpotfabpot approved these changes

@nicolas-grekasnicolas-grekasnicolas-grekas approved these changes

+1 more reviewer

@ogizanagiogizanagiogizanagi approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Projects

None yet

Milestone

2.7

Development

Successfully merging this pull request may close these issues.

5 participants

@HeahDude@nicolas-grekas@fabpot@ogizanagi@carsonbot

[8]ページ先頭

©2009-2025 Movatter.jp