Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
Dump & die function#26906
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Dump & die function#26906
Uh oh!
There was an error while loading.Please reload this page.
Conversation
stof commentedApr 12, 2018
New features arenever added in maintenance branch. And this feature has already been rejected multiple times in the past. |
stloyd commentedApr 12, 2018
gragio commentedApr 12, 2018
Why? Is it too simply? |
curry684 commentedApr 12, 2018
gragio commentedApr 12, 2018 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
I think that it's an added value. Otherwise why was this feature requested multiple times? |
curry684 commentedApr 12, 2018
Count all the people shooting down those 4 requests and the lack of support for them from others 😉 |
gragio commentedApr 13, 2018
@curry684 |
curry684 commentedApr 13, 2018 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
It's code. It has to be maintained. It has to be documented. It's an attack vector. Every line of code in a project is at some point going to be a burden on people managing the project. "Code is not done when there's nothing left to add, but when there's nothing left to take away" Now convenience functions are in themselves not necessarily wrong, assuming they're covering the 80+% use case (technically it becomes afacade then). In this case it most certainly doesn't, I can't remember typing |
chalasr commentedApr 17, 2018
Still -1 for me. |
xabbuh commentedApr 17, 2018
👎 for me too. I am closing here as this was already rejected in the past and the core team still isn't convinced about the feature. |
nicolas-grekas commentedApr 18, 2018
For reference, this is being reconsidered in#26970. |
…s-grekas)This PR was merged into the 4.1-dev branch.Discussion----------[VarDumper] Add dd() helper == dump() + exit()| Q | A| ------------- | ---| Branch? | master| Bug fix? | no| New feature? | yes| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets | -| License | MIT| Doc PR | -By popular demand, I feel like we should reconsider our refusal for a `dd()` global helper.For past references, see#26965,#26906,#13657,#17267,#19096.Commits-------a55916a [VarDumper] Add dd() helper == dump() + die()
Uh oh!
There was an error while loading.Please reload this page.