Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Dump & die function#26906

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed
gragio wants to merge1 commit intosymfony:2.8fromgragio:patch-2
Closed

Dump & die function#26906

gragio wants to merge1 commit intosymfony:2.8fromgragio:patch-2

Conversation

@gragio
Copy link

@gragiogragio commentedApr 12, 2018
edited by nicolas-grekas
Loading

QA
Branch?master
Bug fix?no
New feature?yes
BC breaks?no
Deprecations?no
Tests pass?yes
Fixed tickets#...
LicenseMIT
Doc PRsymfony/symfony-docs#...

alessiodionisi reacted with thumbs up emoji
@stof
Copy link
Member

New features arenever added in maintenance branch.

And this feature has already been rejected multiple times in the past.

@stloyd
Copy link
Contributor

Looks like duplicate of at least#13657,#17267 &#19096.

@gragio
Copy link
Author

Why? Is it too simply?

https://laravel.com/docs/5.6/helpers#method-dd

@curry684
Copy link
Contributor

#13657 (comment)

@gragio
Copy link
Author

gragio commentedApr 12, 2018
edited
Loading

I think that it's an added value. Otherwise why was this feature requested multiple times?

julienbourdeau and drAlberT reacted with thumbs up emoji

@gragiogragio changed the titleDump and die functionDump & die functionApr 12, 2018
@curry684
Copy link
Contributor

Count all the people shooting down those 4 requests and the lack of support for them from others 😉

@gragio
Copy link
Author

@curry684
I'm sorry, I couldn't imagine that this feature can disturb the workflow of all these people 😉

@curry684
Copy link
Contributor

curry684 commentedApr 13, 2018
edited
Loading

It's code. It has to be maintained. It has to be documented. It's an attack vector.

Every line of code in a project is at some point going to be a burden on people managing the project.

"Code is not done when there's nothing left to add, but when there's nothing left to take away"

Now convenience functions are in themselves not necessarily wrong, assuming they're covering the 80+% use case (technically it becomes afacade then). In this case it most certainly doesn't, I can't remember typingdie after adump call more than a handful of times in the past years, because there's never a reason to - the dump shows up in the profiler toolbar, or in the template rendered, or on the command line. What's the added value of dying except in the handful of cases where you actively need to avoid subsequent code being executed based on the bug you're fixing? And which is, in a well architected structure, usually cleaner done by commenting that offending bit of code than just dying and shortcutting all system shutdown handlers, kernel termination handlers, mail spoolers and everything?

jvasseur, xabbuh, and DQNEO reacted with thumbs up emoji

@chalasr
Copy link
Member

Still -1 for me.

@xabbuh
Copy link
Member

👎 for me too. I am closing here as this was already rejected in the past and the core team still isn't convinced about the feature.

@nicolas-grekas
Copy link
Member

For reference, this is being reconsidered in#26970.

gragio reacted with thumbs up emojiquentin-st reacted with thumbs down emoji

fabpot added a commit that referenced this pull requestApr 19, 2018
…s-grekas)This PR was merged into the 4.1-dev branch.Discussion----------[VarDumper] Add dd() helper == dump() + exit()| Q             | A| ------------- | ---| Branch?       | master| Bug fix?      | no| New feature?  | yes| BC breaks?    | no| Deprecations? | no| Tests pass?   | yes| Fixed tickets | -| License       | MIT| Doc PR        | -By popular demand, I feel like we should reconsider our refusal for a `dd()` global helper.For past references, see#26965,#26906,#13657,#17267,#19096.Commits-------a55916a [VarDumper] Add dd() helper == dump() + die()
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Projects

None yet

Milestone

4.1

Development

Successfully merging this pull request may close these issues.

8 participants

@gragio@stof@stloyd@curry684@chalasr@xabbuh@nicolas-grekas@carsonbot

[8]ページ先頭

©2009-2025 Movatter.jp