Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[FrameworkBundle] Messenger requires Serializer#26905

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed
boite wants to merge1 commit intosymfony:masterfromboite:master

Conversation

@boite
Copy link
Contributor

QA
Branch?master
Bug fix?yes
New feature?no
BC breaks?no
Deprecations?no
Tests pass?yes
Fixed tickets-
LicenseMIT
Doc PR-

The new Messenger component's integration with FrameworkBundle (c9cfda9) makes the latterdepend on the Serializer component. This PR moves the dependency fromrequire-dev torequire in composer.json.

@sroze
Copy link
Contributor

It actuallyisn't :).

@chalasr
Copy link
Member

The Messenger component is usable without the Serializer one, it's a soft dependency only. See#26649 which fixed an error when the serializer wasn't installed, should be all good now.

@sroze
Copy link
Contributor

Though, we should work at making the error message clearer. I've already discussed this and I believe the best way is to have theserializer argument of themessenger.transport.serialize_message_with_type_in_headers asif-invalid="null" and throw an exception within the constructor ofSymfony\Component\Messenger\Transport\Serialization\Serializer if$serializer is null. That way, we throw an exception if that default transport is used.

chalasr reacted with thumbs up emoji

@sroze
Copy link
Contributor

Thanks for the PR but as per our comments, I'm going to close this one.

@srozesroze closed thisApr 12, 2018
@boite
Copy link
ContributorAuthor

ah, I see. I was getting this though:-

In CheckExceptionOnInvalidReferenceBehaviorPass.php line 32:  [Symfony\Component\DependencyInjection\Exception\ServiceNotFoundException]     The service "messenger.adapter.amqp.factory" has a dependency on a non-exis    tent service "messenger.transport.default_encoder".

@sroze
Copy link
Contributor

It will be more explicit with#26908 :)

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@boite@sroze@chalasr@carsonbot

[8]ページ先頭

©2009-2025 Movatter.jp