Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Inflector] Support pluralization in the inflector#26890

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fabpot merged 1 commit intosymfony:masterfrommbabker:inflector-pluralization
Mar 31, 2019
Merged

[Inflector] Support pluralization in the inflector#26890

fabpot merged 1 commit intosymfony:masterfrommbabker:inflector-pluralization
Mar 31, 2019

Conversation

@mbabker
Copy link
Contributor

QA
Branch?master
Bug fix?no
New feature?yes
BC breaks?no
Deprecations?no
Tests pass?not yet
Fixed ticketsN/A
LicenseMIT
Doc PRNot Yet

At present the inflector only supports singularizing plural words, this PR adds the capability to pluralize singular words.

@ostrolucky
Copy link
Contributor

Have you read readme of this component?

This component is currently marked as internal. Do not use it in your own code.

I don't see this patch utilized in other components, so why adding unused feature into internal component?

@mbabker
Copy link
ContributorAuthor

In combination with#26903 this allows us in Joomla to drop our inflector (which is in essence stable but unmaintained because we just don't have the resources to keep up with it) for something which is better maintained.

teohhanhui reacted with thumbs up emoji

@fabpot
Copy link
Member

Thank you@mbabker.

mbabker reacted with thumbs up emojichalasr reacted with hooray emoji

@fabpotfabpot merged commit06920a7 intosymfony:masterMar 31, 2019
fabpot added a commit that referenced this pull requestMar 31, 2019
…abker)This PR was merged into the 4.3-dev branch.Discussion----------[Inflector] Support pluralization in the inflector| Q             | A| ------------- | ---| Branch?       | master| Bug fix?      | no| New feature?  | yes| BC breaks?    | no| Deprecations? | no| Tests pass?   | not yet| Fixed tickets | N/A| License       | MIT| Doc PR        | Not YetAt present the inflector only supports singularizing plural words, this PR adds the capability to pluralize singular words.Commits-------06920a7 Support pluralization in the inflector
@mbabkermbabker deleted the inflector-pluralization branchMarch 31, 2019 18:31
@jewome62
Copy link
Contributor

After rebase on master, Test suite on Inflector failed :
Exemple :https://travis-ci.org/symfony/symfony/builds/514143324?utm_source=github_status&utm_medium=notification

@nicolas-grekasnicolas-grekas modified the milestones:next,4.3Apr 30, 2019
@fabpotfabpot mentioned this pull requestMay 9, 2019
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@fabpotfabpotfabpot approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

4.3

Development

Successfully merging this pull request may close these issues.

7 participants

@mbabker@ostrolucky@fabpot@jewome62@nicolas-grekas@xabbuh@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp