Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Console] Don't go past exact matches when autocompleting#26875
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
nicolas-grekas commentedApr 9, 2018
| Q | A |
|---|---|
| Branch? | 2.7 |
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | #21789 |
| License | MIT |
| Doc PR | - |
7da55b3 toe18fcbcComparesrc/Symfony/Component/Console/Tests/Helper/QuestionHelperTest.php OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
e18fcbc to8c9a511Comparesrc/Symfony/Component/Console/Tests/Helper/QuestionHelperTest.php OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
8c9a511 toadba79aCompare| $question =newChoiceQuestion('Please select a city',$possibleChoices); | ||
| $question->setMaxAttempts(1); | ||
| $this->assertSame('b',$dialog->ask($this->createInputInterfaceMock(),$this->createOutputInterface(),$question)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
for merger:createInputInterfaceMock() to be replaced bycreateStreamableInputInterfaceMock() on 3.4
chalasr commentedApr 10, 2018
Thank you@nicolas-grekas. |
…(nicolas-grekas)This PR was merged into the 2.7 branch.Discussion----------[Console] Don't go past exact matches when autocompleting| Q | A| ------------- | ---| Branch? | 2.7| Bug fix? | yes| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets |#21789| License | MIT| Doc PR | -Commits-------adba79a [Console] Don't go past exact matches when autocompleting
lcp0578 commentedJun 5, 2019
on windows MINGW32.
the code: \vendor\symfony\symfony\src\Symfony\Component\Console\Helper\QuestionHelper.php:175 if (false ===$ret) {$ret =fgets($inputStream,4096);if (false ===$ret) {thrownewRuntimeException('Aborted.'); }$ret =trim($ret); } but, when i use cmd.exe i can't input chinese word. |