Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
Add d-block to bootstrap 4 alerts#26870
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
…alar argument (nicolas-grekas)This PR was merged into the 3.4 branch.Discussion----------[DI] Improve error message for non-autowirable scalar argument| Q | A| ------------- | ---| Branch? | 3.4| Bug fix? | yes| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets |symfony#26838| License | MIT| Doc PR | -Commits-------7f39811 [DI] Improve error message for non-autowirable scalar argument
chapterjason commentedApr 11, 2018
Is there any reason why a https://getbootstrap.com/docs/4.0/components/alerts/ Using |
normisg commentedApr 11, 2018
Yes, it was changed in5dcaaad to "Make sure form errors is valid HTML". |
vudaltsov commentedApr 11, 2018
The reason for this is that now error blocks might appear inside |
| {%blockform_errors -%} | ||
| {%-iferrors|length>0 -%} | ||
| <spanclass="{%ifformis notrootform %}invalid-feedback d-block{%else %}alert alert-danger{%endif %}"> | ||
| <spanclass="{%ifformis notrootform %}invalid-feedback d-block{%else %}alert alert-danger d-block{%endif %}"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Let's move thed-block class outside the{% if %} statement to have it only once in the line
…ns in tests (nicolas-grekas)This PR was merged into the 3.4 branch.Discussion----------[HttpKernel] Dont create mock cookie for new sessions in tests| Q | A| ------------- | ---| Branch? | 3.4| Bug fix? | yes| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets |symfony#26493| License | MIT| Doc PR | -@romainneutron can you please check if this fixes your issue?Commits-------86b850e [HttpKernel] Dont create mock cookie for new sessions in tests
nicolas-grekas commentedApr 14, 2018
Thank you@normisg. |
This PR was submitted for the master branch but it was merged into the 3.4 branch instead (closes#26870).Discussion----------Add d-block to bootstrap 4 alerts| Q | A| ------------- | ---| Branch? | master| Bug fix? | yes| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets |#26869| License | MIT| Doc PR | N/ACommits-------40bd8bd Add d-block to bootstrap 4 alerts
Uh oh!
There was an error while loading.Please reload this page.