Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Yaml] Throw parse error on unfinished inline map#26834
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
| if (null !==$delimiters) { | ||
| $tmp =ltrim(substr($scalar,$i),''); | ||
| if ('' ===$tmp) { | ||
| thrownewParseException(sprintf('Unexpected end of line, expected one of "%s".',implode($delimiters))); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
when merging on 3.4:throw new ParseException(sprintf('Unexpected end of line, expected one of "%s".', implode($delimiters)), self::$parsedLineNumber + 1, $scalar, self::$parsedFilename);
| /** | ||
| * @expectedException \Symfony\Component\Yaml\Exception\ParseException | ||
| * @expectedExceptionMessage Unexpected end of line, expected one of ",}". |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
when merging on 3.4:@expectedExceptionMessage Unexpected end of line, expected one of ",}" at line 1 (near "{abc: 'def'").
xabbuh commentedApr 8, 2018
Thank you@nicolas-grekas. |
…-grekas)This PR was merged into the 2.7 branch.Discussion----------[Yaml] Throw parse error on unfinished inline map| Q | A| ------------- | ---| Branch? | 2.7| Bug fix? | yes| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets | -| License | MIT| Doc PR | -Throws a parse error instead of a PHP notice.Commits-------4359936 [Yaml] Throw parse error on unfinished inline map
Throws a parse error instead of a PHP notice.