Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[PhpUnitBridge] Catch deprecation error handler#26794
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
nicolas-grekas merged 1 commit intosymfony:3.4fromcvilleger:catch-deprecation-error-handlerApr 4, 2018
Merged
[PhpUnitBridge] Catch deprecation error handler#26794
nicolas-grekas merged 1 commit intosymfony:3.4fromcvilleger:catch-deprecation-error-handlerApr 4, 2018
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
nicolas-grekas approved these changesApr 4, 2018
Simperfit approved these changesApr 4, 2018
stof approved these changesApr 4, 2018
c315a1f tof40f181CompareMember
nicolas-grekas commentedApr 4, 2018
Thank you@cvilleger. |
nicolas-grekas added a commit that referenced this pull requestApr 4, 2018
This PR was squashed before being merged into the 3.4 branch (closes#26794).Discussion----------[PhpUnitBridge] Catch deprecation error handler| Q | A| ------------- | ---| Branch? | 3.4| Bug fix? | yes| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets |#26476| License | MITThis fix `DeprecationErrorHandler` to catch deprecation triggered by `SymfonyTestListenerTrait`. `$trace[$i]['class']` points to `Symfony\Bridge\PhpUnit\Legacy\SymfonyTestsListenerForV6`, not the aliased version. The condition has been refactored to handle future version `SymfonyTestsListenerForV{x}`Commits-------f40f181 [PhpUnitBridge] Catch deprecation error handler
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fix
DeprecationErrorHandlerto catch deprecation triggered bySymfonyTestListenerTrait.$trace[$i]['class']points toSymfony\Bridge\PhpUnit\Legacy\SymfonyTestsListenerForV6, not the aliased version. The condition has been refactored to handle future versionSymfonyTestsListenerForV{x}