NotificationsYou must be signed in to change notification settings
Fork9.7k
Star30.8k

[DI] Allow autoconfigured calls in PHP#26768

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

fabpot merged 4 commits intosymfony:masterfromGaryPEGEOT:feature/autoconfigure-calls

Apr 20, 2018

Merged

[DI] Allow autoconfigured calls in PHP#26768

fabpot merged 4 commits intosymfony:masterfromGaryPEGEOT:feature/autoconfigure-calls

Apr 20, 2018

Conversation

Copy link

Contributor

GaryPEGEOT commentedApr 3, 2018

Q	A
Branch?	master
Bug fix?	no
New feature?	yes
BC breaks?	no
Deprecations?	no
Tests pass?	yes
Fixed tickets
License	MIT
Doc PR

Allow to auto-configured method calls like:

$container->registerForAutoconfiguration(LoggerAwareInterface::class)->addMethodCall('setLogger',array(newReference(LoggerInterface::class)));

carsonbot added Status: Needs Review Feature labels

Apr 3, 2018

GaryPEGEOT changed the title~~Allow autoconfigured calls in PHP.~~[DI] Allow autoconfigured calls in PHP.

Apr 3, 2018

nicolas-grekas mentioned this pull request

Apr 3, 2018

[DI] Allow auto-configured method calls.#24996

Closed

nicolas-grekas changed the title~~[DI] Allow autoconfigured calls in PHP.~~[DI] Allow autoconfigured calls in PHP

Apr 3, 2018

nicolas-grekas added this to the4.1 milestone

Apr 3, 2018

Gary PEGEOTand others added3 commits

April 4, 2018 01:22

Allow autoconfigured calls in PHP.

2612f81

Add more test-cases

15c45ee

CS fix

71bf3ce

Copy link

ContributorAuthor

GaryPEGEOT commentedApr 6, 2018

@nicolas-grekas I can't reproduce the error in Framework Bundle (Travis pipeline), tests are OK when I run them. Any idea ?

Copy link

Member

nicolas-grekas commentedApr 9, 2018

LGTM.
Can you just add a test with the same method being defined manually AND via instanceof?
(it should be called twice: first by the instanceof, 2nd by the manual definition, isn't it?)

Add test for both _intanceof and manual method setting.

1d811cb

Copy link

ContributorAuthor

GaryPEGEOT commentedApr 10, 2018

Added in1d811cb

nicolas-grekas approved these changes

Apr 10, 2018

View reviewed changes

carsonbot added Status: Reviewed and removed Status: Needs Review labels

Apr 10, 2018

Copy link

Member

fabpot commentedApr 20, 2018

Thank you@GaryPEGEOT.

fabpot merged commit1d811cb intosymfony:master

Apr 20, 2018

fabpot added a commit that referenced this pull request

Apr 20, 2018

feature#26768[DI] Allow autoconfigured calls in PHP (Gary PEGEOT, G…

306c599

…aryPEGEOT)This PR was merged into the 4.1-dev branch.Discussion----------[DI] Allow autoconfigured calls in PHP| Q             | A| ------------- | ---| Branch?       | master| Bug fix?      | no| New feature?  | yes| BC breaks?    |no| Deprecations? | no| Tests pass?   | yes| Fixed tickets || License       | MIT| Doc PR        |Allow to auto-configured method calls like:```php$container->registerForAutoconfiguration(LoggerAwareInterface::class)->addMethodCall('setLogger', array(new Reference(LoggerInterface::class)));```Commits-------1d811cb Add test for both _intanceof and manual method setting.71bf3ce CS fix15c45ee Add more test-cases2612f81 Allow autoconfigured calls in PHP.