Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Console] Use UTF-8 triangle for question prompt#26718
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
ostrolucky left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Tested, doesn't work on windows. Use thesehttps://github.com/sindresorhus/figures
Simperfit commentedMar 31, 2018
@ro0NL did you test it on mac ? doesn't seem to work on mine neither |
rugabarbo commentedMar 31, 2018
It displays as a square (Mac OS X). |
ro0NL commentedMar 31, 2018 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Sorry.. linux-developer here :) Anyway i just got aware of#11326 also.. which seems competing and is a different approach overall. In general something like Status: needs work |
javiereguiluz commentedMar 31, 2018
@ro0NL this one should work on macOS:https://www.utf8icons.com/character/9656/black-right-pointing-small-triangle |
ro0NL commentedMar 31, 2018 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Ok. lets see, if we can ship this little enhancement before#11326 that's nice i guess. New icon works for me :) |
ostrolucky commentedMar 31, 2018 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Works on windows as well. But wouldn't it be better to use the one from#11326? Or is this one going to replace the one there? |
javiereguiluz commentedMar 31, 2018
I'd say the new small triangle looks worse than the existing |
ogizanagi commentedMar 31, 2018 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
I find it a bit too much subtil. Output on OS X (iTerm with 12pt Monaco font): original: new (https://www.utf8icons.com/character/9656/black-right-pointing-small-triangle): What about using the same as in#11326, i.ehttps://www.utf8icons.com/character/10095/heavy-right-pointing-angle-quotation-mark-ornament: ? But anyway it may depends too much on the font used. We won't find a perfect fit. |
ro0NL commentedMar 31, 2018 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
ostrolucky commentedMar 31, 2018
I like ❯ most, even on your screenshot. But it does not work on windows. We could really use Figure helper |
nicolas-grekas commentedMar 31, 2018
lets keep it as is, |
fabpot commentedApr 1, 2018
I think@nicolas-grekas is right. After all, that's not like it's much better and could introduce some bugs on some platforms. For that reason, I'm going to revert#26698, so that we get more time to evaluate the impacts and have only one PR that does all the changes. |
ro0NL commentedApr 1, 2018
Fair. I see the hassle it brings.. What amazes me is this concept of "partial UTF" support accros platforms, totally defeating UTF :D |


Now inspired by#26698, this updates the prompt icon :) Havent looked at tests/windows yet... but i find it very pretty :}
Before
After
Move forward?
refhttps://www.utf8icons.com/character/9205/black-medium-right-pointing-triangle