Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[Console] Use UTF-8 triangle for question prompt#26718

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed
ro0NL wants to merge2 commits intosymfony:masterfromro0NL:console-question-prompt
Closed

[Console] Use UTF-8 triangle for question prompt#26718

ro0NL wants to merge2 commits intosymfony:masterfromro0NL:console-question-prompt

Conversation

@ro0NL
Copy link
Contributor

QA
Branch?master
Bug fix?no
New feature?yes
BC breaks?no
Deprecations?no
Tests pass?yes/no
Fixed tickets#...
LicenseMIT
Doc PRsymfony/symfony-docs#...

Now inspired by#26698, this updates the prompt icon :) Havent looked at tests/windows yet... but i find it very pretty :}

Before

image

After

image

Move forward?

refhttps://www.utf8icons.com/character/9205/black-medium-right-pointing-triangle

Copy link
Contributor

@ostroluckyostrolucky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Tested, doesn't work on windows. Use thesehttps://github.com/sindresorhus/figures

@Simperfit
Copy link
Contributor

@ro0NL did you test it on mac ? doesn't seem to work on mine neither

@rugabarbo
Copy link

It displays as a square (Mac OS X).

@ro0NL
Copy link
ContributorAuthor

ro0NL commentedMar 31, 2018
edited
Loading

Sorry.. linux-developer here :) Anyway i just got aware of#11326 also.. which seems competing and is a different approach overall.

In general something likeConsole\Figure::render('⏵', '>'); would be nice.

Status: needs work

ostrolucky reacted with thumbs up emoji

@javiereguiluz
Copy link
Member

@ro0NL
Copy link
ContributorAuthor

ro0NL commentedMar 31, 2018
edited
Loading

Ok. lets see, if we can ship this little enhancement before#11326 that's nice i guess.

New icon works for me :)

@ostrolucky
Copy link
Contributor

ostrolucky commentedMar 31, 2018
edited
Loading

Works on windows as well. But wouldn't it be better to use the one from#11326? Or is this one going to replace the one there?

@javiereguiluz
Copy link
Member

I'd say the new small triangle looks worse than the existing> char 😢

ogizanagi, ostrolucky, and jvasseur reacted with thumbs up emoji

@ogizanagi
Copy link
Contributor

ogizanagi commentedMar 31, 2018
edited
Loading

I find it a bit too much subtil. Output on OS X (iTerm with 12pt Monaco font):

original:

screenshot 2018-03-31 a 12 26 19

new (https://www.utf8icons.com/character/9656/black-right-pointing-small-triangle):

screenshot 2018-03-31 a 12 21 14

What about using the same as in#11326, i.ehttps://www.utf8icons.com/character/10095/heavy-right-pointing-angle-quotation-mark-ornament:

screenshot 2018-03-31 a 12 21 26

?

But anyway it may depends too much on the font used. We won't find a perfect fit.

@ro0NL
Copy link
ContributorAuthor

ro0NL commentedMar 31, 2018
edited
Loading

Last triangle on my side:
image

Proposed chevron on my side:
image

Hence i chose a smaller triangle ;-) but im willing to settle, no problem. In PHPStorm it looks better.

@ostrolucky
Copy link
Contributor

I like ❯ most, even on your screenshot. But it does not work on windows. We could really use Figure helper

@nicolas-grekas
Copy link
Member

lets keep it as is,> is really fine, and prevents from adding code for dealing with non-UTF-8 consoles.

ostrolucky, jvasseur, and Simperfit reacted with thumbs up emoji

@nicolas-grekasnicolas-grekas added this to the4.1 milestoneMar 31, 2018
@fabpot
Copy link
Member

I think@nicolas-grekas is right. After all, that's not like it's much better and could introduce some bugs on some platforms. For that reason, I'm going to revert#26698, so that we get more time to evaluate the impacts and have only one PR that does all the changes.

ogizanagi reacted with thumbs up emoji

@ro0NL
Copy link
ContributorAuthor

Fair. I see the hassle it brings..

What amazes me is this concept of "partial UTF" support accros platforms, totally defeating UTF :D

stephanvierkant reacted with thumbs up emoji

@ro0NLro0NL closed thisApr 1, 2018
@ro0NLro0NL deleted the console-question-prompt branchApril 1, 2018 08:32
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

1 more reviewer

@ostroluckyostroluckyostrolucky requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Projects

None yet

Milestone

4.1

Development

Successfully merging this pull request may close these issues.

9 participants

@ro0NL@Simperfit@rugabarbo@javiereguiluz@ostrolucky@ogizanagi@nicolas-grekas@fabpot@carsonbot

[8]ページ先頭

©2009-2025 Movatter.jp