Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Console] Use UTF-8 bullet for listing#26698
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
javiereguiluz commentedMar 28, 2018
Be careful. That's one of the multiple characters that don't work on Windows. Seehttps://github.com/sindresorhus/figures |
ro0NL commentedMar 28, 2018
Now ready :) |
| privatefunctiongetFixtureFilename($name) | ||
| { | ||
| $format =$this->getFormat(); | ||
| $file = ($baseDir =__DIR__.'/../../Fixtures/Descriptor').'/'.$name.'.'.$format; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
can you move the$baseDir assignement to its own statement ? Nested assignments are not that readable.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Done.
ogizanagi commentedMar 28, 2018 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Duplicating expected outputs for Windows may be unwanted. Can't we use matchesFormat or str_replace bullets instead (and create a dedicated test case for this behavior)? |
ro0NL commentedMar 28, 2018
the files are globbed.. i found this the easiest, To maintain and be future proof. Not aiming for in-test formatting hassle / excluding these fixtures into separate tests. |
fabpot commentedMar 30, 2018
Thank you@ro0NL. |
This PR was squashed before being merged into the 4.1-dev branch (closes#26698).Discussion----------[Console] Use UTF-8 bullet for listing| Q | A| ------------- | ---| Branch? | master| Bug fix? | no| New feature? | yes| BC breaks? | no <!-- seehttps://symfony.com/bc -->| Deprecations? | no| Tests pass? | yes| Fixed tickets | #... <!-- #-prefixed issue number(s), if any -->| License | MIT| Doc PR | symfony/symfony-docs#... <!-- required for new features -->Inspired by the new table style, this updates the listing style.beforeafterCommits-------d1e4acb [Console] Use UTF-8 bullet for listing
fabpot commentedApr 1, 2018
reverted, see discussion on#26718 |
Uh oh!
There was an error while loading.Please reload this page.
Inspired by the new table style, this updates the listing style.
before
after