Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
Support phpdbg SAPI in Debug::enable()#26677
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
nicolas-grekas commentedMar 26, 2018
Would be ok as bug fix on 2.7 on my side. |
PHPDBG is a CLI PHP debugger which could be useful for debugging in developmentor for running PHPUnit tests with code coverage faster compared to XDebug.It has CLI characteristics, but it runs as a different SAPI.
hkdobrev commentedMar 26, 2018
@nicolas-grekas Updated as a bug fix on top of 2.7. |
| 2.7.1 | ||
| ----- | ||
| * fix support for PHPDBG SAPI in`Debug::enable()` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This must be reverted. We only add new entries on minor versions, for features.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Done.
hkdobrev commentedMar 26, 2018
On a separate note, there are quite a few places where checks for CLI hard-code the |
fabpot commentedMar 27, 2018
Thank you@hkdobrev. |
This PR was squashed before being merged into the 2.7 branch (closes#26677).Discussion----------Support phpdbg SAPI in Debug::enable()| Q | A| ------------- | ---| Branch? | 2.7| Bug fix? | yes| New feature? | no <!-- don't forget to update src/**/CHANGELOG.md files -->| BC breaks? | no <!-- seehttps://symfony.com/bc -->| Deprecations? | no <!-- don't forget to update UPGRADE-*.md and src/**/CHANGELOG.md files -->| Tests pass? | yes <!-- please add some, will be required by reviewers -->| Fixed tickets | <!-- #-prefixed issue number(s), if any -->| License | MIT| Doc PR | <!-- required for new features -->PHPDBG is a CLI PHP debugger which could be useful for debugging in development or for running PHPUnit tests with code coverage faster compared to XDebug.It has CLI characteristics, but it runs as a different SAPI.Commits-------49a144f Support phpdbg SAPI in Debug::enable()
ogizanagi commentedMar 27, 2018
@hkdobrev : Yes, if there are other places where this makes sense, a PR fixing it all is always appreciated :) |
This PR was squashed before being merged into the 2.7 branch (closes#26749).Discussion----------Add PHPDbg support to HTTP components| Q | A| ------------- | ---| Branch? | 2.7| Bug fix? | yes| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets || License | MIT| Doc PR |This is a follow-up to#26677.Turns out there aren't that many remaining instances of `PHP_SAPI` checks without considering `phpdbg` where it's needed.Commits-------60dd79c Add PHPDbg support to HTTP components
Uh oh!
There was an error while loading.Please reload this page.
PHPDBG is a CLI PHP debugger which could be useful for debugging in development or for running PHPUnit tests with code coverage faster compared to XDebug.
It has CLI characteristics, but it runs as a different SAPI.