Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
Improved the Ajax profiler panel when there are exceptions#26665
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
ostrolucky left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Some unnecessary moving of code blocks, increasing likehood of merge conflicts, but I'll let others decide how important that is
javiereguiluz commentedMar 25, 2018
@ostrolucky the main problem is moving this line -> |
ostrolucky commentedMar 25, 2018
Yes I see your reasoning. I would do the same in most codebases too. |
fabpot commentedMar 27, 2018
Thank you@javiereguiluz. |
…ions (javiereguiluz)This PR was merged into the 4.1-dev branch.Discussion----------Improved the Ajax profiler panel when there are exceptions| Q | A| ------------- | ---| Branch? | master| Bug fix? | no| New feature? | yes| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets |#26646| License | MIT| Doc PR | -This makes the following changes in the Ajax panel:* The `Profiler` column is now the first one.* When the response status code is `400` or higher, the profiler link points to the exception panel instead of the default request/response panelCommits-------074d68d Improved the Ajax profiler panel when there are exceptions
This makes the following changes in the Ajax panel:
Profilercolumn is now the first one.400or higher, the profiler link points to the exception panel instead of the default request/response panel