NotificationsYou must be signed in to change notification settings
Fork9.7k
Star30.8k

[Translation] XLIFF2: Make sure to trim source if it is too long for "name"#26661

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

fabpot merged 1 commit intosymfony:masterfromNyholm:translation-xliff-name

Mar 30, 2018

Merged

[Translation] XLIFF2: Make sure to trim source if it is too long for "name"#26661

fabpot merged 1 commit intosymfony:masterfromNyholm:translation-xliff-name

Mar 30, 2018

Conversation

Copy link

Member

Nyholm commentedMar 23, 2018

Q	A
Branch?	master
Bug fix?	yes
New feature?	no
BC breaks?	no
Deprecations?	no
Tests pass?	yes
Fixed tickets
License	MIT
Doc PR

This PR is a follow-up on@javiereguiluz's comment here:symfony/symfony-docs#9302

This feature was introduced in#26149

carsonbot added Status: Needs Review Translation Bug labels

Mar 23, 2018

nicolas-grekas added this to the4.1 milestone

Mar 24, 2018

Make sure to trim source if it is too long

ca41fec

Nyholm force-pushed thetranslation-xliff-name branch frome485a5b toca41fecCompare

March 27, 2018 07:49

Copy link

MemberAuthor

Nyholm commentedMar 27, 2018

I've rebased my PR on master to make Travis happy.

Copy link

Member

javiereguiluz commentedMar 27, 2018

I'm not sure about this because translations will have different kinds ofid depending on its contents:

<trans-unitid="http_error_403.suggestion"> ... </trans-unit><trans-unitid="ca41fec"> ... </trans-unit>

Why can't we just apply this md5 ID to all translation nodes? Why it's important to duplicate the translation contents in theid too? XLIFF is already verbose and this is not helping 😓

Copy link

MemberAuthor

Nyholm commentedMar 27, 2018

As mentioned in#25758

For backward compatibility I don't expect to see a change to the way the element is used, but for the 1.2 and 2.0 formats to be treated as equivalent it seems the same logic should be applied.

So we usesource asname to be similar to 1.2.

fabpot approved these changes

Mar 30, 2018

View reviewed changes

carsonbot added Status: Reviewed and removed Status: Needs Review labels

Mar 30, 2018

Copy link

Member

fabpot commentedMar 30, 2018

Thank you@Nyholm.

fabpot merged commitca41fec intosymfony:master

Mar 30, 2018

fabpot added a commit that referenced this pull request

Mar 30, 2018

bug#26661[Translation] XLIFF2: Make sure to trim source if it is to…

9b25573

…o long for "name" (Nyholm)This PR was merged into the 4.1-dev branch.Discussion----------[Translation] XLIFF2: Make sure to trim source if it is too long for "name"| Q             | A| ------------- | ---| Branch?       | master| Bug fix?      | yes| New feature?  | no| BC breaks?    | no| Deprecations? | no| Tests pass?   | yes| Fixed tickets || License       | MIT| Doc PR        |This PR is a follow-up on@javiereguiluz's comment here:symfony/symfony-docs#9302This feature was introduced in#26149Commits-------ca41fec Make sure to trim source if it is too long

Nyholm deleted the translation-xliff-name branch

February 24, 2021 09:26