Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Messenger] Remove the default transport if noserializer service#26649

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

@sroze
Copy link
Contributor

@srozesroze commentedMar 23, 2018•
edited
Loading

QA
Branch?master
Bug fix?yes
New feature?no
BC breaks?no
Deprecations?no
Tests pass?yes
Fixed ticketsø
LicenseMIT

If theserializer service does not exist, we remove the default transport services as they rely on it.

@linaori
Copy link
Contributor

Might be a silly question, but why add it in the first place? Why not only add it if the serializer isn't available?

@chalasr
Copy link
Member

@iltar Good question, AFAIK we use that approach in general. I guess having as much services as possible declared in xml is good for discoverability

linaori, ogizanagi, sroze, and xabbuh reacted with thumbs up emoji

@srozesroze merged commit2bcf93d intosymfony:masterMar 26, 2018
sroze added a commit that referenced this pull requestMar 26, 2018
…` service (sroze)This PR was merged into the 4.1-dev branch.Discussion----------[Messenger] Remove the default transport if no `serializer` service| Q             | A| ------------- | ---| Branch?       | master| Bug fix?      | yes| New feature?  | no| BC breaks?    | no| Deprecations? | no| Tests pass?   | yes| Fixed tickets | ø| License       | MITIf the `serializer` service does not exist, we remove the default transport services as they rely on it.Commits-------2bcf93d Remove the default transport if no serializer
@srozesroze deleted the messenger-remove-default-transport-if-no-serializer branchMarch 26, 2018 20:00
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@nicolas-grekasnicolas-grekasnicolas-grekas approved these changes

@chalasrchalasrchalasr approved these changes

+1 more reviewer

@ogizanagiogizanagiogizanagi approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Projects

None yet

Milestone

4.1

Development

Successfully merging this pull request may close these issues.

6 participants

@sroze@linaori@chalasr@nicolas-grekas@ogizanagi@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp