Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[SecurityBundle] Added an alias from RoleHierarchyInterface to security.role_hierarchy#26639

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

@lyrixx
Copy link
Member

@lyrixxlyrixx commentedMar 22, 2018
edited
Loading

QA
Branch?master
Bug fix?I don't know
New feature?no
BC breaks?no
Deprecations?no
Tests pass?yes
Fixed tickets
LicenseMIT
Doc PR

It's needed for autowirering


Note: I'm not sure if this is a bug fix or a new feature.

<serviceid="security.role_hierarchy"class="Symfony\Component\Security\Core\Role\RoleHierarchy">
<argument>%security.role_hierarchy.roles%</argument>
</service>
<serviceid="Symfony\Component\Security\Core\Role\RoleHierarchy"alias="security.role_hierarchy" />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Should beRoleHierarchyInterface to me

Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Arf, I noticed that too, but it looks like I forgot to push. Thanks.

@lyrixxlyrixxforce-pushed theRoleHierarchyInterface-alias branch fromd7ba849 to886b8a6CompareMarch 22, 2018 16:50
@chalasr
Copy link
Member

Thank you@lyrixx.

@chalasrchalasr merged commit886b8a6 intosymfony:masterMar 23, 2018
chalasr pushed a commit that referenced this pull requestMar 23, 2018
…rface to security.role_hierarchy (lyrixx)This PR was merged into the 4.1-dev branch.Discussion----------[SecurityBundle] Added an alias from RoleHierarchyInterface to security.role_hierarchy| Q             | A| ------------- | ---| Branch?       | master| Bug fix?      | I don't know| New feature?  | no| BC breaks?    | no| Deprecations? | no| Tests pass?   | yes| Fixed tickets || License       | MIT| Doc PR        |It's needed for autowirering---Note: I'm not sure if this is a bug fix or a new feature.Commits-------886b8a6 [SecurityBundle] Added an alias from RoleHierarchyInterface to security.role_hierarchy
@lyrixxlyrixx deleted the RoleHierarchyInterface-alias branchMarch 23, 2018 09:10
@buffcode
Copy link
Contributor

Will this be backported to 3.4?

@lyrixx
Copy link
MemberAuthor

@buffcode No, it's a new feature and all new features go to master.
Buy you can easily add this alias inyourservices.yml ;)

buffcode reacted with thumbs up emoji

@buffcode
Copy link
Contributor

Thanks for clarification, yeah I know it is easy to add.
I'm just adding this to any 3.4 project as of now, so it's some kind of PITA ;)

@fabpotfabpot mentioned this pull requestMay 7, 2018
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@nicolas-grekasnicolas-grekasnicolas-grekas approved these changes

@xabbuhxabbuhxabbuh approved these changes

@chalasrchalasrchalasr approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

4.1

Development

Successfully merging this pull request may close these issues.

6 participants

@lyrixx@chalasr@buffcode@nicolas-grekas@xabbuh@carsonbot

[8]ページ先頭

©2009-2025 Movatter.jp