Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[DI] deprecate TypedReference::canBeAutoregistered() and getRequiringClass()#26636

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

@nicolas-grekas
Copy link
Member

@nicolas-grekasnicolas-grekas commentedMar 22, 2018•
edited
Loading

QA
Branch?master
Bug fix?no
New feature?no
BC breaks?no
Deprecations?yes
Tests pass?yes
Fixed tickets-
LicenseMIT
Doc PR-

Needs#26634

@stof
Copy link
Member

I would also make it returnfalse all the time (maybe even in 4.0), as no reference can be auto-registered in 4.0 😄

@nicolas-grekasnicolas-grekasforce-pushed thedi-deprec-autoreg branch 2 times, most recently fromfdbddaa to4137a30CompareMarch 22, 2018 13:58
@nicolas-grekasnicolas-grekas changed the title[DI] deprecate TypedReference::canBeAutoregistered()[DI] deprecate TypedReference::canBeAutoregistered() and getRequiringClass()Mar 22, 2018
@nicolas-grekas
Copy link
MemberAuthor

nicolas-grekas commentedMar 22, 2018•
edited
Loading

This PR now also deprecatesTypedReference::getRequiringClass() since it's also not used.

return false all the time

hum, I'd better not do this, for hypothetical BC breaks and easing merges...

@nicolas-grekasnicolas-grekas merged commit95fd81b intosymfony:masterMar 22, 2018
nicolas-grekas added a commit that referenced this pull requestMar 22, 2018
…nd getRequiringClass() (nicolas-grekas)This PR was merged into the 4.1-dev branch.Discussion----------[DI] deprecate TypedReference::canBeAutoregistered() and getRequiringClass()| Q             | A| ------------- | ---| Branch?       | master| Bug fix?      | no| New feature?  | no| BC breaks?    | no| Deprecations? | yes| Tests pass?   | yes| Fixed tickets | -| License       | MIT| Doc PR        | -~Needs#26634~Commits-------95fd81b [DI] deprecate TypedReference::canBeAutoregistered() and getRequiringClass()
@nicolas-grekasnicolas-grekas deleted the di-deprec-autoreg branchMarch 22, 2018 14:57
@fabpotfabpot mentioned this pull requestMay 7, 2018
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Projects

None yet

Milestone

4.1

Development

Successfully merging this pull request may close these issues.

3 participants

@nicolas-grekas@stof@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp