Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[DI] Cleanup remainings from autoregistration#26634
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
nicolas-grekas commentedMar 22, 2018
| Q | A |
|---|---|
| Branch? | 4.0 |
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | #25959 |
| License | MIT |
| Doc PR | - |
3d5a111 to0847a20Compare0847a20 to74afff8Compare| return$reference; | ||
| } | ||
| if (!$reference->canBeAutoregistered()) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
iscanBeAutoregistered still used anywhere ? AFAICT, this PR removes the only usages of the method. We should probably deprecate it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
We should probably deprecate it.
Yes, we can now in 4.1
…kas)This PR was merged into the 4.0 branch.Discussion----------[DI] Cleanup remainings from autoregistration| Q | A| ------------- | ---| Branch? | 4.0| Bug fix? | yes| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets |#25959| License | MIT| Doc PR | -Commits-------74afff8 [DI] Cleanup remainings from autoregistration
…nd getRequiringClass() (nicolas-grekas)This PR was merged into the 4.1-dev branch.Discussion----------[DI] deprecate TypedReference::canBeAutoregistered() and getRequiringClass()| Q | A| ------------- | ---| Branch? | master| Bug fix? | no| New feature? | no| BC breaks? | no| Deprecations? | yes| Tests pass? | yes| Fixed tickets | -| License | MIT| Doc PR | -~Needs#26634~Commits-------95fd81b [DI] deprecate TypedReference::canBeAutoregistered() and getRequiringClass()