Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Workflow] removed bc break#26615
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
lyrixx commentedMar 21, 2018
| Q | A |
|---|---|
| Branch? | master |
| Bug fix? | no |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | |
| Tests pass? | yes |
| Fixed tickets | #26076 |
| License | MIT |
| Doc PR |
| } | ||
| publicfunctionsetBlocked(bool$blocked):void | ||
| publicfunctionsetBlocked(bool$blocked) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
the argument type hint needs to be removed too
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
🤦♂️ Good catch. Sorry about this waste of time.
a5300cc to685695dComparefabpot commentedMar 21, 2018
Thank you@lyrixx. |
This PR was merged into the 4.1-dev branch.Discussion----------[Workflow] removed bc break| Q | A| ------------- | ---| Branch? | master| Bug fix? | no| New feature? | no| BC breaks? | no| Deprecations? || Tests pass? | yes| Fixed tickets |#26076| License | MIT| Doc PR |Commits-------685695d [Workflow] removed bc break