Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[RFC] [PropertyAccess] Allow using read and write access info for users#26613

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed
joelwurtz wants to merge1 commit intosymfony:masterfromjoelwurtz:patch-1

Conversation

joelwurtz
Copy link
Contributor

@joelwurtzjoelwurtz commentedMar 21, 2018
edited
Loading

QA
Branch?master
Bug fix?no
New feature?yes
BC breaks?no
Deprecations?no
Tests pass?yes
LicenseMIT

Goal of this PR is to be able to retrieve more informations on the read / write acess info (accessor / mutator).

I have an use case where i need to get which accessor or mutator is used to read or write on a property for a specific class. My intent behind that is to generate the code instead of relying on the property acessor component, as i know that my schema will not change (or that the changes are never done on runtime and can be cached at each deployement). To be more clear this is something that i need to redo#17516 (but in a different way)

However there is other ways to do that and i am not sure that this change should be here, as there is some options:

1. Public methods

This is the changes that are here, also instead of returning an array this method could provide an object.
A new interface would be created (in order to have BC with the existing PropertyAcessorInterface)

2. Porting this code to the PropertyInfo component

Getting the accessor / mutator info on a property may be more suitable in the PropertyInfo component. So this code would be ported to the PropertyInfo component. Then a follow up PR could make PropertyAccess use the data from the PropertyInfo component (however it would induce a new required dependency for the PropertyAccess component)

3. Not wanted

Just close this PR then :)

PS: This is cleary not a finished PR and changes are only here to better describe my intent, i will do a new PR (or not) depending on the following discussion (as this is a RFC)

@carsonbotcarsonbot added Status: Needs Review RFCRFC = Request For Comments (proposals about features that you want to be discussed) PropertyAccess Bug Feature labelsMar 21, 2018
@nicolas-grekasnicolas-grekas added RFCRFC = Request For Comments (proposals about features that you want to be discussed) and removed Bug RFCRFC = Request For Comments (proposals about features that you want to be discussed) labelsMar 22, 2018
@nicolas-grekasnicolas-grekas added this to the4.1 milestoneMar 22, 2018
@nicolas-grekasnicolas-grekas modified the milestones:4.1,nextApr 20, 2018
@fabpot
Copy link
Member

I don't like option 1 very much. Option 2 might be the best choice (and I like 3 as well :))

@fabpot
Copy link
Member

@joelwurtz What's the status of this PR?

@joelwurtz
Copy link
ContributorAuthor

Those Accessor / Mutator extractors have been written in#30248 (since that where there are useful)

I think we can close this, and depending on what is discussed in#30248 i will make a new PR with those extractor

@joelwurtzjoelwurtz deleted the patch-1 branchFebruary 21, 2019 13:01
@nicolas-grekasnicolas-grekas modified the milestones:next,4.3Apr 30, 2019
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
FeaturePropertyAccessRFCRFC = Request For Comments (proposals about features that you want to be discussed)Status: Needs Review
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.

4 participants
@joelwurtz@fabpot@nicolas-grekas@carsonbot

[8]ページ先頭

©2009-2025 Movatter.jp