Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[PHPunit] suite variable should be used#26612
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
lyrixx approved these changesMar 21, 2018
fabpot approved these changesMar 21, 2018
Member
fabpot commentedMar 21, 2018
Thank you@prisis. |
fabpot added a commit that referenced this pull requestMar 21, 2018
This PR was merged into the 3.4 branch.Discussion----------[PHPunit] suite variable should be used| Q | A| ------------- | ---| Branch? | 3.4| Bug fix? | yes| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets || License | MITIf you using phpunit V7 with the CoverageListener you getting a error with `Undefined variable: test`Commits-------8b8541e [PHPunit] suite variable should be used
Contributor
greg0ire commentedSep 16, 2018
Good catch, but wrong fix I'm afraid. Right now I'm getting this failure: A PR is on its way :) |
greg0ire added a commit to greg0ire/symfony that referenced this pull requestSep 16, 2018
Calling the trait with a TestSuite argument will have no effect, it willexit quickly because of a test added in25e0117, that checks that $suite is a TestCaseinstance.Refssymfony#26612
greg0ire added a commit to greg0ire/symfony that referenced this pull requestSep 16, 2018
Calling the trait with a TestSuite argument will have no effect, it willexit quickly because of a test added in25e0117, that checks that $suite is a TestCaseinstance.Refssymfony#26612
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If you using phpunit V7 with the CoverageListener you getting a error with
Undefined variable: test