Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Routing] Fixed the importing of files using glob patterns that match multiple resources#26600
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
… multiple resources
skalpa commentedMar 19, 2018
Failures are unrelated. Also, I didn't know which branch to target: the source of the problem is a change in |
nicolas-grekas commentedMar 19, 2018
@skalpa thank you. Branch 3.4 is the good one. I think |
skalpa commentedMar 19, 2018
@nicolas-grekas I took care of |
| $collection = $routes->collection(); | ||
| $collection->add('bar_route', '/bar') | ||
| ->defaults(['_controller' => 'AppBundle:Bar:view']); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
array() instead of[] (same below, see fabbot patch)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Sorry, old habits. Fixed.
nicolas-grekas commentedMar 22, 2018
Thank you@skalpa. |
… that match multiple resources (skalpa)This PR was squashed before being merged into the 3.4 branch (closes#26600).Discussion----------[Routing] Fixed the importing of files using glob patterns that match multiple resources| Q | A| ------------- | ---| Branch? | 3.4| Bug fix? | yes| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets |#22160| License | MIT| Doc PR | n/aThis fixes the import of resources specified using glob patterns in `XmlFileLoader` and `YamlFileLoader`.@nicolas-grekas This supersedes#25633 that's been in limbo since December despite your comments, so I decided to take care of it as I need this to work. I took care of the two loaders that are affected, and added tests.Commits-------948b4cf [Routing] Fixed the importing of files using glob patterns that match multiple resources
Uh oh!
There was an error while loading.Please reload this page.
This fixes the import of resources specified using glob patterns in
XmlFileLoaderandYamlFileLoader.@nicolas-grekas This supersedes#25633 that's been in limbo since December despite your comments, so I decided to take care of it as I need this to work. I took care of the two loaders that are affected, and added tests.