Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
Add hint in Github pull request template#26580
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
.github/PULL_REQUEST_TEMPLATE.md Outdated
| | New feature? | yes/no<!-- don't forget to update src/**/CHANGELOG.md files--> | ||
| | BC breaks? | no<!-- see https://symfony.com/bc--> | ||
| | Deprecations? | yes/no<!-- don't forget to update UPGRADE-*.md files--> | ||
| | Deprecations? | yes/no<!-- don't forget to update UPGRADE-*.mdand CHANGELOG.mdfiles--> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This is ambiguous as people must not change theCHANGELOG-*.md in the root directory, but only the ones from the bridge/bundle/component directories.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Indeed, updated as "New feature?" withsrc/**/CHANGELOG.md.
fabpot commentedMar 18, 2018
Thank you@fmata. |
This PR was merged into the 2.7 branch.Discussion----------Add hint in Github pull request template| Q | A| ------------- | ---| Branch? | 2.7| Bug fix? | no| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| License | MITI added a deprecation in the code base but I forgot to update the CHANGELOG.md file of the component although I double checked the pull request template of this case.It's trivial but I think it can be a way to save some time for next distracted contributors :)Commits-------986f915 add hint in Github pull request template
I added a deprecation in the code base but I forgot to update the CHANGELOG.md file of the component although I double checked the pull request template of this case.
It's trivial but I think it can be a way to save some time for next distracted contributors :)