NotificationsYou must be signed in to change notification settings
Fork9.7k
Star30.8k

[Serializer] Remove const override#26551

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

nicolas-grekas merged 1 commit intosymfony:3.4fromogizanagi:minor/serializer/remove_dup_const

Mar 16, 2018

Merged

[Serializer] Remove const override#26551

nicolas-grekas merged 1 commit intosymfony:3.4fromogizanagi:minor/serializer/remove_dup_const

Mar 16, 2018

Conversation

Copy link

Contributor

ogizanagi commentedMar 15, 2018•
edited
Loading

Q	A
Branch?	3.4
Bug fix?	no
New feature?	no
BC breaks?	no
Deprecations?	no
Tests pass?	yes
Fixed tickets	N/A
License	MIT
Doc PR	N/A

This public const was moved to parent class in#24816

[Serializer] Remove const override

25312c4

carsonbot added Status: Needs Review Serializer labels

Mar 15, 2018

javiereguiluz added Status: Reviewed and removed Status: Needs Review labels

Mar 16, 2018

javiereguiluz approved these changes

Mar 16, 2018

View reviewed changes

javiereguiluz added this to the3.4 milestone

Mar 16, 2018

nicolas-grekas approved these changes

Mar 16, 2018

View reviewed changes

Simperfit approved these changes

Mar 16, 2018

View reviewed changes

Copy link

Member

nicolas-grekas commentedMar 16, 2018

Thank you@ogizanagi.

nicolas-grekas merged commit25312c4 intosymfony:3.4

Mar 16, 2018

nicolas-grekas added a commit that referenced this pull request

Mar 16, 2018

minor#26551[Serializer] Remove const override (ogizanagi)

866a142

This PR was merged into the 3.4 branch.Discussion----------[Serializer] Remove const override| Q             | A| ------------- | ---| Branch?       | 3.4| Bug fix?      | no| New feature?  | no <!-- don't forget to update src/**/CHANGELOG.md files -->| BC breaks?    | no     <!-- seehttps://symfony.com/bc -->| Deprecations? | no <!-- don't forget to update UPGRADE-*.md files -->| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->| Fixed tickets | N/A   <!-- #-prefixed issue number(s), if any -->| License       | MIT| Doc PR        | N/AThis public const was moved to parent class in#24816Commits-------25312c4 [Serializer] Remove const override

ogizanagi deleted the minor/serializer/remove_dup_const branch

March 16, 2018 09:32