Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
Added some HTML5 features to the Symfony Profiler#26520
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
nicolas-grekas approved these changesMar 14, 2018
Member
nicolas-grekas left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
(failure unrelated)
Simperfit approved these changesMar 14, 2018
Contributor
linaori commentedMar 14, 2018
I always love these changes to the profiler, because in fact, Iam the end-user of this "product" 👍 |
fabpot approved these changesMar 14, 2018
ogizanagi approved these changesMar 14, 2018
dunglas approved these changesMar 15, 2018
Member
fabpot commentedMar 15, 2018
Thank you@javiereguiluz. |
fabpot added a commit that referenced this pull requestMar 15, 2018
…iereguiluz)This PR was merged into the 4.1-dev branch.Discussion----------Added some HTML5 features to the Symfony Profiler| Q | A| ------------- | ---| Branch? | master| Bug fix? | no| New feature? | yes| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets | -| License | MIT| Doc PR | -Some of these changes are invisible to end-users, but others may be nice tweaks:1) Times now display full details when you hover them:2) The "profile search" results are now better aligned:### Before### After3) The "profile search" form now validates URLs and HTTP Status numbers:I've decided to not use the new and recommended HTML5 `datetime-local` input type for "From" and "Until" fields because support is still poor in desktop browsers.Commits-------547076e Added some HTML5 features to the Symfony Profiler
javiereguiluz added a commit to EasyCorp/EasyAdminBundle that referenced this pull requestMar 16, 2018
…lated properties (javiereguiluz)This PR was merged into the 1.x branch.Discussion----------Use the HTML <time> element to display date and time related propertiesSimilar to what we recently did to Symfony:symfony/symfony#26520Commits-------8677b5b Use the HTML <time> element to display date and time related properties
Merged
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
Feature❄️ Feature FreezeImportant Pull Requests to finish before the next Symfony "feature freeze" Status: ReviewedWebProfilerBundle
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some of these changes are invisible to end-users, but others may be nice tweaks:
Before
After
I've decided to not use the new and recommended HTML5
datetime-localinput type for "From" and "Until" fields because support is still poor in desktop browsers.