Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[HttpFoundation] split FileException into specialized ones about upload handling#26475
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
soullivaneuh left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Looks good, thanks! 👍
| * | ||
| * @author Florent Mata <florentmata@gmail.com> | ||
| */ | ||
| class CantWriteFileException extends FileException |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I would nose Cant here but Cannot instead.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I wanted to follow the PHP constUPLOAD_ERR_CANT_WRITE to keep consistency, as others exceptions added in this PR. Are you sure of this change ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
@fmata can you please do the change? (and rebase meanwhile to fix the small conflict)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
@nicolas-grekas rebased & updated
| namespace Symfony\Component\HttpFoundation\File\Exception; | ||
| /** | ||
| * Thrown when an error UPLOAD_ERR_CANT_WRITE occurred with UploadedFile. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I would swap the word "error" and the name of the error.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Updated
fmata commentedApr 2, 2018
Status: Needs Review |
fabpot commentedApr 3, 2018
Thank you@fmata. |
…ones about upload handling (fmata)This PR was merged into the 4.1-dev branch.Discussion----------[HttpFoundation] split FileException into specialized ones about upload handling| Q | A| ------------- | ---| Branch? | master| Bug fix? | no| New feature? | yes| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets |#26411| License | MITCommits-------9e586cc [HttpFoundation] split FileException into specialized ones about upload handling
Uh oh!
There was an error while loading.Please reload this page.