Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
Make ProgressBar::setMaxSteps public#26449
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Destroy666x commentedMar 8, 2018
A test for the described use case would be nice. Also a test for setting the value for a progress bar that didn't have max steps earlier. |
ostrolucky commentedMar 8, 2018
This is simple setter and is tested by proxy in existing integration tests. Will write test if required by maintainers. |
Simperfit commentedMar 8, 2018
If you change from private to public, I think a test is needed. |
ostrolucky commentedMar 8, 2018
test added |
| privatefunctionsetMaxSteps(int$max) | ||
| publicfunctionsetMaxSteps(int$max) | ||
| { | ||
| $this->format =null; |
nicolas-grekasMar 12, 2018 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
is this a bug fix? or a behavioral BC break?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Bug fix. Wasn't issue before though, because this method was being called on the start only. Please note that format explicitly set by user is saved in different property.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
got it
what about moving the method up with other public ones?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
will do
This is useful in cases when target of trackingchanges its size during progress advancement.
fabpot commentedMar 19, 2018
Thank you@ostrolucky. |
This PR was merged into the 4.1-dev branch.Discussion----------Make ProgressBar::setMaxSteps public| Q | A| ------------- | ---| Branch? | master| Bug fix? | no| New feature? | yes| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets |#24100| License | MIT| Doc PR | -This is useful in cases when target of tracking changes its size during progress advancement. My exact use case is showing progress of file upload for file which is still being downloading.Commits-------2b3c37a Make ProgressBar::setMaxSteps public
Uh oh!
There was an error while loading.Please reload this page.
This is useful in cases when target of tracking changes its size during progress advancement. My exact use case is showing progress of file upload for file which is still being downloading.