Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[DomCrawler] extract(): fix a bug when the attribute list is empty#26433
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
dunglas commentedMar 6, 2018
| Q | A |
|---|---|
| Branch? | 2.7 |
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | n/a |
| License | MIT |
| Doc PR | n/a |
stof commentedMar 7, 2018
does it even make sense to support an empty list of extracted attributes ? |
dunglas commentedMar 10, 2018
@stof the method should either return an empty array (like in my patch) or throw, but a notice isn't acceptable. Returning an empty array if an empty list of args has been provided looks ok to me, but I can change to an exception, your call. |
fabpot commentedMar 13, 2018
Thank you@dunglas. |
…is empty (dunglas)This PR was merged into the 2.7 branch.Discussion----------[DomCrawler] extract(): fix a bug when the attribute list is empty| Q | A| ------------- | ---| Branch? | 2.7| Bug fix? | yes| New feature? | no <!-- don't forget to update src/**/CHANGELOG.md files -->| BC breaks? | no <!-- seehttps://symfony.com/bc -->| Deprecations? | no <!-- don't forget to update UPGRADE-*.md files -->| Tests pass? | yes <!-- please add some, will be required by reviewers -->| Fixed tickets | n/a <!-- #-prefixed issue number(s), if any -->| License | MIT| Doc PR | n/aCommits-------028c9f2 [DomCrawler] extract(): fix a bug when the attribute list is empty