we use$constructor = $r->getConstructor() to get the constructor (and your code here breaks in case there is no constructor). Add this logic after the retrieval of$constructor.

And I would check insteadContainer::class !== $contructor->getDeclaringClass(), to exclude only the Container constructor.

you mean$constructor->getDeclaringClass() === Container::class ?

should be!==, not=== We want to call the parent constructor when it is a custom one.

that doesn't fix the issue .. since in the MockContainer the declaring class of the constructor is the Container class, since the MockContainer doesn't define its own constructor

and that's precisely the goal: wedon't want to call the parent constructor for the MockContainer case (otherwise, you would not have a bug currently when it is called).

The Container constructor initializes the ParameterBag, and the dumped container wants to do it in its own way.

but in that case we don't want to call the parent ..
if I do!== the bug remains .. I have confirmed this, because we still end up calling the parent constructor.

your code is adding theparent::__constructonly when the declaring class of the constructor is Container now.

ah you are right .. the issue was that it needed to be$constructor->getDeclaringClass()->name and not$constructor->getDeclaringClass() in the comparison.

Should we create a new test case to still keep the existing one (a class without a constructor not inheriting one from its base class)?

I was also thinking about that .. and to me the old test just seemed incomplete since that class didn't even implement the interface.