Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Form][WCAG] Fixed HTML errors#26328
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
nicolas-grekas left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
that is odd, but that's the standard
fabpot commentedFeb 27, 2018
This one is indeed rather odd. Anyway, let's merge this one in 3.4. I would also change the other forms, but only on master (4.1). |
fabpot commentedFeb 27, 2018
Thank you@Nyholm. |
This PR was squashed before being merged into the 3.4 branch (closes#26328).Discussion----------[Form][WCAG] Fixed HTML errors| Q | A| ------------- | ---| Branch? | 3.4| Bug fix? | yes| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets || License | MIT| Doc PR |According to my friend and WCAG2 expect [Sandra](https://twitter.com/sandrability):> Fix your HTML errors.Should I fix the same issues on other forms as well? Or could someone claim that is a BC break?Commits-------fe66819 [Form][WCAG] Fixed HTML errors
Nyholm commentedFeb 27, 2018
Thank you for merging. I'll fix the other forms as well |
This PR was merged into the 4.1-dev branch.Discussion----------[FORM] Fix HTML errors.| Q | A| ------------- | ---| Branch? | master| Bug fix? | yes| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets || License | MIT| Doc PR |As mentioned in#26328.Range and color do not support "required" attributeCommits-------f75d8c1 Fix HTML errors.
According to my friend and WCAG2 expectSandra:
Should I fix the same issues on other forms as well? Or could someone claim that is a BC break?